refactor: enforce non-quoted type annotations

Enable ruff rules UP037 and FA to forbid quoted type annotations. Plain type
annotations are cleaner, more readable, and enable better IDE support and
type checking compared to string literals.

Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>

Author: glehmann

lib/host.py

@@ -52,7 +52,7 @@ def host_data(hostname_or_ip: str) -> dict[str, str]:
 
 class Host:
     xe_prefix = "host"
-    pool: "Pool"
+    pool: Pool
 
     # Data extraction is automatic, no conversion from str is done.
     BlockDeviceInfo = TypedDict('BlockDeviceInfo', {"name": str,

lib/vm.py

@@ -656,7 +656,7 @@ def create_cd_vbd(self, device: str, userdevice: str) -> VBD:
         logging.info("New VBD %s", vbd_uuid)
         return vbd
 
-    def clone(self, *, name: str | None = None) -> "VM":
+    def clone(self, *, name: str | None = None) -> VM:
         if name is None:
             name = self.name() + '_clone_for_tests'
         logging.info("Clone VM")

pyproject.toml

@@ -51,12 +51,14 @@ quote-style = "preserve"
 [tool.ruff.lint]
 select = [
   "D",  # pydocstyle
+  "FA",  # future-annotations
   "F",  # Pyflakes
   "I",  # isort
   "SLF",  # flake8-self
   "SIM",  # flake8-simplify
   "UP006",  # non-pep585-annotation
   "UP007",  # non-pep604-annotation-union
+  "UP037",  # quoted-annotation
 ]
 # don't use some of the default D and SIM rules
 ignore = [