storage: test that we can't create a vdi over its max allowed size

Depending on the image format.

Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>

Author: glehmann

tests/storage/__init__.py

@@ -1,4 +1,5 @@
 from .storage import (
+    MAX_VDI_SIZE,
     CoalesceOperation,
     ImageFormat,
     XVACompression,

tests/storage/ext/test_ext_sr.py

@@ -12,6 +12,7 @@
 from lib.vdi import VDI
 from lib.vm import VM
 from tests.storage import (
+    MAX_VDI_SIZE,
     CoalesceOperation,
     ImageFormat,
     XVACompression,
@@ -105,6 +106,12 @@ def test_vdi_export_import(self, storage_test_vm: VM, ext_sr: SR, image_format:
     def test_full_vdi_write(self, storage_test_vm: VM, vdi_on_ext_sr: VDI, defer: Defer):
         full_vdi_write(storage_test_vm, vdi_on_ext_sr, defer)
 
+    @pytest.mark.small_vm
+    def test_invalid_vdi_size(self, ext_sr: SR, image_format: ImageFormat):
+        with pytest.raises(SSHCommandFailed) as excinfo:
+            ext_sr.create_vdi(virtual_size=MAX_VDI_SIZE[image_format] + 1)
+        assert 'VDI Invalid size' in excinfo.value.stdout
+
     # *** tests with reboots (longer tests).
 
     @pytest.mark.small_vm

tests/storage/lvm/test_lvm_sr.py

@@ -12,6 +12,7 @@
 from lib.vdi import VDI
 from lib.vm import VM
 from tests.storage import (
+    MAX_VDI_SIZE,
     CoalesceOperation,
     ImageFormat,
     XVACompression,
@@ -148,6 +149,12 @@ def test_coalesce(self, storage_test_vm: VM, vdi_on_lvm_sr: VDI, vdi_op: Coalesc
     def test_full_vdi_write(self, storage_test_vm: VM, vdi_on_lvm_sr: VDI, defer: Defer):
         full_vdi_write(storage_test_vm, vdi_on_lvm_sr, defer)
 
+    @pytest.mark.small_vm
+    def test_invalid_vdi_size(self, lvm_sr: SR, image_format: ImageFormat):
+        with pytest.raises(SSHCommandFailed) as excinfo:
+            lvm_sr.create_vdi(virtual_size=MAX_VDI_SIZE[image_format] + 1)
+        assert 'VDI Invalid size' in excinfo.value.stdout
+
     @pytest.mark.small_vm
     @pytest.mark.parametrize("compression", ["none", "gzip", "zstd"])
     def test_xva_export_import(self, vm_on_lvm_sr: VM, compression: XVACompression, temp_large_dir: str, defer: Defer):

tests/storage/lvmoiscsi/test_lvmoiscsi_sr.py

@@ -1,10 +1,12 @@
 import pytest
 
+from lib.commands import SSHCommandFailed
 from lib.common import Defer, vm_image, wait_for
 from lib.sr import SR
 from lib.vdi import VDI
 from lib.vm import VM
 from tests.storage import (
+    MAX_VDI_SIZE,
     CoalesceOperation,
     ImageFormat,
     XVACompression,
@@ -72,6 +74,12 @@ def test_coalesce(self, storage_test_vm: 'VM', vdi_on_lvmoiscsi_sr: 'VDI', vdi_o
     def test_full_vdi_write(self, storage_test_vm: VM, vdi_on_lvmoiscsi_sr: VDI, defer: Defer):
         full_vdi_write(storage_test_vm, vdi_on_lvmoiscsi_sr, defer)
 
+    @pytest.mark.small_vm
+    def test_invalid_vdi_size(self, lvmoiscsi_sr: SR, image_format: ImageFormat):
+        with pytest.raises(SSHCommandFailed) as excinfo:
+            lvmoiscsi_sr.create_vdi(virtual_size=MAX_VDI_SIZE[image_format] + 1)
+        assert 'VDI Invalid size' in excinfo.value.stdout
+
     @pytest.mark.small_vm
     @pytest.mark.parametrize("compression", ["none", "gzip", "zstd"])
     def test_xva_export_import(self, vm_on_lvmoiscsi_sr: VM, compression: XVACompression, temp_large_dir: str,

tests/storage/nfs/test_nfs_sr.py

@@ -8,6 +8,7 @@
 from lib.vdi import VDI
 from lib.vm import VM
 from tests.storage import (
+    MAX_VDI_SIZE,
     CoalesceOperation,
     ImageFormat,
     XVACompression,
@@ -123,6 +124,12 @@ def test_coalesce(self, storage_test_vm: VM, dispatch_nfs: VDI, vdi_op: Coalesce
     def test_full_vdi_write(self, storage_test_vm: VM, vdi_on_nfs_sr: VDI, defer: Defer):
         full_vdi_write(storage_test_vm, vdi_on_nfs_sr, defer)
 
+    @pytest.mark.small_vm
+    def test_invalid_vdi_size(self, nfs_sr: SR, image_format: ImageFormat):
+        with pytest.raises(SSHCommandFailed) as excinfo:
+            nfs_sr.create_vdi(virtual_size=MAX_VDI_SIZE[image_format] + 1)
+        assert 'VDI Invalid size' in excinfo.value.stdout
+
     @pytest.mark.small_vm
     # Make sure this fixture is called before the parametrized one
     @pytest.mark.usefixtures('vm_ref')

tests/storage/storage.py

@@ -14,6 +14,8 @@
 
 from typing import Literal, Tuple
 
+MAX_VDI_SIZE: dict[ImageFormat, int] = {'qcow2': 16 * TiB, 'vhd': 2040 * GiB}
+
 def try_to_create_sr_with_missing_device(sr_type, label, host):
     try:
         host.sr_create(sr_type, label, {}, verify=True)

tests/storage/xfs/test_xfs_sr.py

@@ -12,6 +12,7 @@
 from lib.vdi import VDI
 from lib.vm import VM
 from tests.storage import (
+    MAX_VDI_SIZE,
     CoalesceOperation,
     ImageFormat,
     XVACompression,
@@ -114,6 +115,12 @@ def test_coalesce(
     def test_full_vdi_write(self, storage_test_vm: VM, vdi_on_xfs_sr: VDI, defer: Defer):
         full_vdi_write(storage_test_vm, vdi_on_xfs_sr, defer)
 
+    @pytest.mark.small_vm
+    def test_invalid_vdi_size(self, xfs_sr: SR, image_format: ImageFormat):
+        with pytest.raises(SSHCommandFailed) as excinfo:
+            xfs_sr.create_vdi(virtual_size=MAX_VDI_SIZE[image_format] + 1)
+        assert 'VDI Invalid size' in excinfo.value.stdout
+
     @pytest.mark.small_vm
     @pytest.mark.parametrize("compression", ["none", "gzip", "zstd"])
     def test_xva_export_import(self, vm_on_xfs_sr: VM, compression: XVACompression, temp_large_dir: str, defer: Defer):

tests/storage/zfs/test_zfs_sr.py

@@ -11,6 +11,7 @@
 from lib.vdi import VDI
 from lib.vm import VM
 from tests.storage import (
+    MAX_VDI_SIZE,
     CoalesceOperation,
     ImageFormat,
     XVACompression,
@@ -114,6 +115,12 @@ def test_coalesce(self, storage_test_vm: VM, vdi_on_zfs_sr: VDI, vdi_op: Coalesc
     def test_full_vdi_write(self, storage_test_vm: VM, vdi_on_zfs_sr: VDI, defer: Defer):
         full_vdi_write(storage_test_vm, vdi_on_zfs_sr, defer)
 
+    @pytest.mark.small_vm
+    def test_invalid_vdi_size(self, zfs_sr: SR, image_format: ImageFormat):
+        with pytest.raises(SSHCommandFailed) as excinfo:
+            zfs_sr.create_vdi(virtual_size=MAX_VDI_SIZE[image_format] + 1)
+        assert 'VDI Invalid size' in excinfo.value.stdout
+
     @pytest.mark.small_vm
     @pytest.mark.parametrize("compression", ["none", "gzip", "zstd"])
     def test_xva_export_import(self, vm_on_zfs_sr: VM, compression: XVACompression, temp_large_dir: str, defer: Defer):

tests/storage/zfsvol/test_zfsvol_sr.py

@@ -5,12 +5,14 @@
 import logging
 
 from lib import config
+from lib.commands import SSHCommandFailed
 from lib.common import Defer, KiB, MiB, vm_image, wait_for
 from lib.host import Host
 from lib.sr import SR
 from lib.vdi import VDI
 from lib.vm import VM
 from tests.storage import (
+    MAX_VDI_SIZE,
     CoalesceOperation,
     ImageFormat,
     XVACompression,
@@ -81,6 +83,13 @@ def test_coalesce(self, storage_test_vm: VM, vdi_on_zfsvol_sr: VDI, vdi_op: Coal
     def test_full_vdi_write(self, storage_test_vm: VM, vdi_on_zfsvol_sr: VDI, defer: Defer):
         full_vdi_write(storage_test_vm, vdi_on_zfsvol_sr, defer)
 
+    @pytest.mark.small_vm
+    @pytest.mark.xfail(reason="not implemented yet")
+    def test_invalid_vdi_size(self, zfsvol_sr: SR, image_format: ImageFormat):
+        with pytest.raises(SSHCommandFailed) as excinfo:
+            zfsvol_sr.create_vdi(virtual_size=MAX_VDI_SIZE[image_format] + 1)
+        assert 'VDI Invalid size' in excinfo.value.stdout
+
     @pytest.mark.small_vm
     @pytest.mark.parametrize("compression", ["none", "gzip", "zstd"])
     def test_xva_export_import(