Remove 3 occurences of typing.cast

Signed-off-by: Vincent Michel <vincent.michel@vates.tech>

Author: vxgmichel

lib/host.py

@@ -31,7 +31,7 @@
 from lib.vm import VM
 from lib.xo import xo_cli, xo_object_exists
 
-from typing import TYPE_CHECKING, Literal, TypedDict, cast, overload
+from typing import TYPE_CHECKING, Literal, TypedDict, overload
 
 if TYPE_CHECKING:
     from lib.pool import Pool
@@ -121,9 +121,8 @@ def ssh(self, cmd: str, *, check: bool = True, simple_output: bool = True,
 
     @overload
     def ssh(self, cmd: str, *, check: bool = True, simple_output: bool = True,
-            suppress_fingerprint_warnings: bool = True, background: bool = False, decode: bool = True,
-            multiplexing: bool = True) \
-            -> str | bytes | commands.SSHResult[str] | commands.SSHResult[bytes] | None:
+            suppress_fingerprint_warnings: bool = True, background: Literal[False] = False,
+            decode: Literal[True] = True, multiplexing: bool = True) -> str | commands.SSHResult[str]:
         ...
 
     def ssh(self, cmd: str, *, check: bool = True, simple_output: bool = True,
@@ -258,7 +257,7 @@ def execute_script(self, script_contents: str, shebang: str = 'sh',
 
             try:
                 logging.debug(f"[{self}] # Will execute this temporary script:\n{script_contents.strip()}")
-                return cast(str | commands.SSHResult, self.ssh(remote_path, simple_output=simple_output))
+                return self.ssh(remote_path, simple_output=simple_output)
             finally:
                 self.ssh(f'rm -f {remote_path}')
 

lib/vm.py

@@ -27,7 +27,7 @@
 from lib.vdi import VDI
 from lib.vif import VIF
 
-from typing import TYPE_CHECKING, Iterable, List, Literal, cast, overload
+from typing import TYPE_CHECKING, Iterable, List, Literal, overload
 
 if TYPE_CHECKING:
     from lib.host import Host
@@ -130,8 +130,8 @@ def ssh(self, cmd: str, *, check: bool = True, simple_output: bool = True,
         ...
 
     @overload
-    def ssh(self, cmd: str, *, check: bool = True, simple_output: bool = True, background: bool = False,
-            decode: bool = True) -> str | bytes | commands.SSHResult[str] | commands.SSHResult[bytes] | None:
+    def ssh(self, cmd: str, *, check: bool = True, simple_output: bool = True,
+            background: Literal[False] = False, decode: Literal[True] = True) -> str | commands.SSHResult[str]:
         ...
 
     def ssh(self, cmd: str, *, check: bool = True, simple_output: bool = True, background: bool = False,
@@ -463,7 +463,7 @@ def execute_script(self, script_contents: str, simple_output: bool = True) -> st
                 logging.debug(f"[{self.ip}] # Will execute this temporary script:\n{script_contents.strip()}")
                 # Use bash to run the script, to avoid being hit by differences between shells, for example on FreeBSD
                 # It is a documented requirement that bash is present on all test VMs.
-                res = cast(str | commands.SSHResult, self.ssh(f'bash {f.name}', simple_output=simple_output))
+                res = self.ssh(f'bash {f.name}', simple_output=simple_output)
                 return res
             finally:
                 self.ssh(f'rm -f {f.name}')
@@ -801,10 +801,10 @@ def execute_powershell_script(
         if prepend is not None:
             script_contents = prepend + script_contents
         cmd = commands.encode_powershell_command(script_contents)
-        return cast(str | commands.SSHResult, self.ssh(
+        return self.ssh(
             f"powershell.exe -nologo -noprofile -noninteractive -encodedcommand {cmd}",
             simple_output=simple_output,
-        ))
+        )
 
     def run_powershell_command(self, program: str, args: str) -> int:
         """