Skip to content

Commit c4f93a7

Browse files
committed
storage: skip zfsvol large VDI tests due to known performance issue
Skip test_xva_export_import and test_vdi_export_import when VDI size > 20 GiB, as performance issues make these tests too slow on large volumes. Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
1 parent ff7e16d commit c4f93a7

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

tests/storage/zfsvol/test_zfsvol_sr.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
from lib import config
88
from lib.commands import SSHCommandFailed
9-
from lib.common import Defer, KiB, MiB, vm_image, wait_for
9+
from lib.common import Defer, GiB, KiB, MiB, vm_image, wait_for
1010
from lib.host import Host
1111
from lib.sr import SR
1212
from lib.vdi import VDI
@@ -97,11 +97,15 @@ def test_invalid_vdi_size(self, zfsvol_sr: SR, image_format: ImageFormat):
9797
@pytest.mark.parametrize("compression", ["none", "gzip", "zstd"])
9898
def test_xva_export_import(self, vm_on_zfsvol_sr: VM, compression: XVACompression, temp_large_dir: str,
9999
defer: Defer) -> None:
100+
if config.volume_size > 20 * GiB:
101+
pytest.skip("Skipping large VDI test (known performance issue)")
100102
xva_export_import(vm_on_zfsvol_sr, compression, temp_large_dir, defer)
101103

102104
@pytest.mark.small_vm
103105
def test_vdi_export_import(self, storage_test_vm: VM, zfsvol_sr: SR, image_format: ImageFormat, temp_large_dir: str,
104106
defer: Defer) -> None:
107+
if config.volume_size > 20 * GiB:
108+
pytest.skip("Skipping large VDI test (known performance issue)")
105109
vm = storage_test_vm
106110
sr = zfsvol_sr
107111
vdi_export_import(vm, sr, image_format, temp_large_dir, defer)

0 commit comments

Comments
 (0)