Add "slow" as a new non-default marker

The "slow" marker designates tests that may take a long time and are
designed to catch rare issues that may need large datasets or multiple
repetitions to be reproduced.

Add the following tests to reproduce the following rare issues:
* test_migrate_repeat: Windows migration issues associated with the
  XenVbd driver
* test_create_and_destroy_sr_repeat: NFS deadlock issue

Add a new `multi/slow` VM list for this purpose.

Signed-off-by: Tu Dinh <ngoc-tu.dinh@vates.tech>

Author: dinhngtu

conftest.py

@@ -48,7 +48,7 @@
 
 # pytest hooks
 
-NONDEFAULT_MARKERS = ["reboot", "flaky"]
+NONDEFAULT_MARKERS = ["reboot", "flaky", "slow"]
 
 def pytest_addoption(parser: pytest.Parser):
     parser.addoption(

jobs.py

@@ -468,7 +468,22 @@
             "--vm[]": "multi/limits",
         },
         "paths": ["tests/limits"],
-    }
+    },
+    "slow": {
+        "description": "tests that may take a long time",
+        "requirements": [
+            "Will vary depending on the tests included.",
+            "Use the collect command to get the list of tests "
+            + "and check the requirements written at the top of the test files.",
+        ],
+        "nb_pools": 1,
+        "params": {
+            "--enable-slow": True,
+            "--vm[]": "multi/slow",
+        },
+        "paths": ["tests"],
+        "markers": "slow",
+    },
 }
 
 # List used by the 'check' action: tests listed here will not raise a check error

pytest.ini

@@ -37,6 +37,7 @@ markers =
     flaky: flaky tests. Usually pass, but sometimes fail unexpectedly.
     complex_prerequisites: tests whose prerequisites are complex and may require special attention.
     quicktest: runs `quicktest`.
+    slow: tests that may take a long time, designed to catch rare issues.
 log_level = debug
 log_cli = 1
 log_cli_level = info

tests/misc/test_vm_basic_operations.py

@@ -19,6 +19,19 @@ def test_suspend(self, running_vm: VM):
         vm.resume()
         vm.wait_for_vm_running_and_ssh_up()
 
+    @pytest.mark.slow
+    @pytest.mark.parametrize("attempt", range(100))
+    def test_migrate_repeat(self, running_vm: VM, attempt: int):
+        """
+        Perform a "fast" stress test of the suspend mechanism by repeatedly migrating onto the same host.
+
+        We don't use the usual suspend call, but use local migrations to avoid hitting the disk and/or network.
+        """
+        vm = running_vm
+        residence = vm.get_residence_host()
+        vm.migrate(residence)
+        vm.wait_for_vm_running_and_ssh_up()
+
     def test_snapshot(self, running_vm: VM):
         vm = running_vm
         vm.test_snapshot_on_running_vm()

tests/storage/iso/test_nfs_iso_sr.py

@@ -35,6 +35,12 @@ def test_create_and_destroy_sr(self, host, nfs_iso_device_config):
         sr = host.sr_create('iso', "ISO-NFS-SR-test", nfs_iso_device_config, shared=True, verify=True)
         sr.forget()
 
+    @pytest.mark.slow
+    @pytest.mark.parametrize("attempt", range(100))
+    def test_create_and_destroy_sr_repeat(self, host, nfs_iso_device_config, attempt: int):
+        """Look for potential issues in the NFS subsystem by stress testing the connection and disconnection code."""
+        self.test_create_and_destroy_sr(host, nfs_iso_device_config)
+
 
 @pytest.mark.small_vm
 @pytest.mark.usefixtures("nfs_iso_sr")

vm_data.py-dist

@@ -65,6 +65,11 @@ VMS["multi"]["limits"] = [vm for vm in [
     VMS["single"]["small_vm_windows"],
 ] if vm]
 
+VMS["multi"]["slow"] = [vm for vm in [
+    VMS["single"]["small_vm"],
+    VMS["single"]["small_vm_windows"],
+] if vm]
+
 # Example of use for a common XVA_LOCATION
 #
 # XVA_LOCATION="http://somewhere/"