host_no_sdn_controller: do not fail, but reconfigure the host. - #680
Merged
Conversation
Contributor
Author
|
The purpose of this PR is to be able to run both tests requiring sdn-controller ( |
glehmann
reviewed
Aug 25, 2026
semarie
force-pushed
the
srt/no-sdn-controller
branch
from
August 26, 2026 08:10
0bc1845 to
562cf57
Compare
Contributor
Author
|
Last push:
|
glehmann
approved these changes
Aug 27, 2026
glehmann
left a comment
glehmann
left a comment
Member
There was a problem hiding this comment.
LGTM for the code structure, but I can't say the same for the network part, by lack of knowledge in that domain.
when a 'no-sdn-controller' host is required (for test_vif_allowed_ip.py for example), do not fail if sdn-controller is active, but disable it for the test (and restore it after). we get the sdn-controller configuration to reapply it after the test, and reconfigure the ovs bridges to accept both OpenFlow10 and OpenFlow11 versions. OpenFlow11 is usual used for sdn-controller (xapi-plugin) and OpenFlow10 for allowed-ip (see xen-api ocaml/xenopsd/scripts/setup-vif-rules). Signed-off-by: Sebastien Rodot <sebastien.rodot@vates.tech>
semarie
force-pushed
the
srt/no-sdn-controller
branch
from
August 27, 2026 11:23
562cf57 to
a10e76e
Compare
gthvn1
approved these changes
Sep 4, 2026
|
|
||
| # when using sdn-controller, we are usually using OpenFlow11 only | ||
| # but allow-id is using OpenFlow10 and it fails to sets rules if OpenFlow11 is enabled only. | ||
| host.ssh("set -o pipefail; ovs-vsctl list-br " |
Contributor
There was a problem hiding this comment.
if ovs-vsctl raised all forgotten sdn will remain forgotten. Not sure if it is a real issue.
Contributor
Author
There was a problem hiding this comment.
it shouldn't be a problem. the set -o pipefail was added due to @glehmann remark as "if it raises it means OVS is completely off, and we are already in bad shape"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when a 'no-sdn-controller' host is required (for test_vif_allowed_ip.py for example), do not fail if sdn-controller is active, but disable it for the test (and restore it after).
we get the sdn-controller configuration to reapply it after the test, and reconfigure the ovs bridges to accept both OpenFlow10 and OpenFlow11 versions. OpenFlow11 is usual used for sdn-controller (xapi-plugin) and OpenFlow10 for allowed-ip (see xen-api ocaml/xenopsd/scripts/setup-vif-rules).