Merge pull request #37 from xcube-dev/konstntokas/correct_indices_mapping

Fix bug in rectify_dataset with output_indices_names

Author: konstntokas

CHANGES.md

@@ -1,13 +1,20 @@
+## Changes in 0.3.5 (in development)
+
+- Fixed a bug in `rectify_dataset` where the conversion from block-space indices to 
+  global-space indices was incorrect when `output_indices_names` was provided.
+
 ## Changes in 0.3.4
 
 - Added `utils.transform_resolution` to convert spatial resolution between coordinate 
   reference systems (CRS).
 
+
 ## Changes in 0.3.3
 
 - Added function `utils.resolution_degrees_to_meters` to convert spatial resolution
   from degrees to meters at a given geographic latitude.
 
+
 ## Changes in 0.3.2
 
 - Change inconsistent license classifier in `pyproject.toml` 

xcube_resampling/rectify.py

@@ -287,7 +287,7 @@ def _downscale_source_dataset(
     interp_methods: Mapping[Hashable, SpatialInterpMethod],
     agg_methods: SpatialAggMethods | None,
     prevent_nan_propagations: PreventNaNPropagations,
-) -> (xr.Dataset, GridMapping):
+) -> tuple[xr.Dataset, GridMapping]:
     if all(v in (0, "nearest") for v in interp_methods.values()):
         return source_ds, source_gm
 

xcube_resampling/utils.py

@@ -851,10 +851,10 @@ def _map_to_source_indices(pixel_target_ij, indexing):
     """
     offsets_x = da.zeros_like(pixel_target_ij[0])
     offsets_y = da.zeros_like(pixel_target_ij[1])
+    th = offsets_x.chunksize[0]
+    tw = offsets_x.chunksize[1]
 
     ny, nx = indexing.ij_bboxes.shape[1:]
-    th, tw = indexing.tile_size
-
     for j in range(ny):
         for i in range(nx):
             bbox = indexing.ij_bboxes[:, j, i]

xcube_resampling/version.py

@@ -19,4 +19,4 @@
 # FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
 # DEALINGS IN THE SOFTWARE.
 
-__version__ = "0.3.4"
+__version__ = "0.3.5.dev0"