Skip to content

Commit 0a70a8a

Browse files
committed
fixed tests
1 parent 09509b5 commit 0a70a8a

File tree

4 files changed

+23
-15
lines changed

4 files changed

+23
-15
lines changed

test/core/resampling/test_affine.py

+16-12
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ class AffineTransformDatasetTest(unittest.TestCase):
4646
def test_subset(self):
4747
target_gm = GridMapping.regular((3, 3), (50.0, 10.0), res, source_gm.crs)
4848
target_ds = affine_transform_dataset(
49-
source_ds, source_gm, target_gm, gm_name="crs"
49+
source_ds, source_gm=source_gm, target_gm=target_gm, gm_name="crs"
5050
)
5151
self.assertIsInstance(target_ds, xr.Dataset)
5252
self.assertEqual(
@@ -66,7 +66,7 @@ def test_subset(self):
6666

6767
target_gm = GridMapping.regular((3, 3), (50.1, 10.1), res, source_gm.crs)
6868
target_ds = affine_transform_dataset(
69-
source_ds, source_gm, target_gm, gm_name="crs"
69+
source_ds, source_gm=source_gm, target_gm=target_gm, gm_name="crs"
7070
)
7171
self.assertIsInstance(target_ds, xr.Dataset)
7272
self.assertEqual(
@@ -86,7 +86,7 @@ def test_subset(self):
8686

8787
target_gm = GridMapping.regular((3, 3), (50.05, 10.05), res, source_gm.crs)
8888
target_ds = affine_transform_dataset(
89-
source_ds, source_gm, target_gm, gm_name="crs"
89+
source_ds, source_gm=source_gm, target_gm=target_gm, gm_name="crs"
9090
)
9191
self.assertIsInstance(target_ds, xr.Dataset)
9292
self.assertEqual(
@@ -102,13 +102,15 @@ def test_different_geographic_crses(self):
102102
expected = np.array([[1.25, 1.5, 0.75], [1.0, 1.25, 1.5], [1.75, 1.0, 1.25]])
103103

104104
target_gm = GridMapping.regular((3, 3), (50.05, 10.05), res, CRS_WGS84)
105-
target_ds = affine_transform_dataset(source_ds, source_gm, target_gm)
105+
target_ds = affine_transform_dataset(
106+
source_ds, source_gm=source_gm, target_gm=target_gm
107+
)
106108
self.assertEqual((3, 3), target_ds.refl.shape)
107109
np.testing.assert_almost_equal(target_ds.refl.values, expected)
108110

109111
target_gm = GridMapping.regular((3, 3), (50.05, 10.05), res, CRS_CRS84)
110112
target_ds = affine_transform_dataset(
111-
source_ds, source_gm, target_gm, gm_name="crs"
113+
source_ds, source_gm=source_gm, target_gm=target_gm, gm_name="crs"
112114
)
113115
self.assertEqual((3, 3), target_ds.refl.shape)
114116
np.testing.assert_almost_equal(target_ds.refl.values, expected)
@@ -122,12 +124,14 @@ def test_different_geographic_crses(self):
122124
' must be equal, was "WGS 84" and'
123125
' "ETRS89-extended / LAEA Europe"',
124126
):
125-
affine_transform_dataset(source_ds, source_gm, target_gm)
127+
affine_transform_dataset(
128+
source_ds, source_gm=source_gm, target_gm=target_gm
129+
)
126130

127131
def test_downscale_x2(self):
128132
target_gm = GridMapping.regular((8, 6), (50, 10), 2 * res, source_gm.crs)
129133
target_ds = affine_transform_dataset(
130-
source_ds, source_gm, target_gm, gm_name="crs"
134+
source_ds, source_gm=source_gm, target_gm=target_gm, gm_name="crs"
131135
)
132136
self.assertIsInstance(target_ds, xr.Dataset)
133137
self.assertEqual(
@@ -152,7 +156,7 @@ def test_downscale_x2(self):
152156
def test_downscale_x2_and_shift(self):
153157
target_gm = GridMapping.regular((8, 6), (49.8, 9.8), 2 * res, source_gm.crs)
154158
target_ds = affine_transform_dataset(
155-
source_ds, source_gm, target_gm, gm_name="crs"
159+
source_ds, source_gm=source_gm, target_gm=target_gm, gm_name="crs"
156160
)
157161
self.assertIsInstance(target_ds, xr.Dataset)
158162
self.assertEqual(
@@ -177,7 +181,7 @@ def test_downscale_x2_and_shift(self):
177181
def test_upscale_x2(self):
178182
target_gm = GridMapping.regular((8, 6), (50, 10), res / 2, source_gm.crs)
179183
target_ds = affine_transform_dataset(
180-
source_ds, source_gm, target_gm, gm_name="crs"
184+
source_ds, source_gm=source_gm, target_gm=target_gm, gm_name="crs"
181185
)
182186
self.assertIsInstance(target_ds, xr.Dataset)
183187
self.assertEqual(
@@ -202,7 +206,7 @@ def test_upscale_x2(self):
202206
def test_upscale_x2_and_shift(self):
203207
target_gm = GridMapping.regular((8, 6), (49.9, 9.95), res / 2, source_gm.crs)
204208
target_ds = affine_transform_dataset(
205-
source_ds, source_gm, target_gm, gm_name="crs"
209+
source_ds, source_gm=source_gm, target_gm=target_gm, gm_name="crs"
206210
)
207211
self.assertIsInstance(target_ds, xr.Dataset)
208212
self.assertEqual(
@@ -227,7 +231,7 @@ def test_upscale_x2_and_shift(self):
227231
def test_shift(self):
228232
target_gm = GridMapping.regular((8, 6), (50.2, 10.1), res, source_gm.crs)
229233
target_ds = affine_transform_dataset(
230-
source_ds, source_gm, target_gm, gm_name="crs"
234+
source_ds, source_gm=source_gm, target_gm=target_gm, gm_name="crs"
231235
)
232236
self.assertIsInstance(target_ds, xr.Dataset)
233237
self.assertEqual(
@@ -251,7 +255,7 @@ def test_shift(self):
251255

252256
target_gm = GridMapping.regular((8, 6), (49.8, 9.9), res, source_gm.crs)
253257
target_ds = affine_transform_dataset(
254-
source_ds, source_gm, target_gm, gm_name="crs"
258+
source_ds, source_gm=source_gm, target_gm=target_gm, gm_name="crs"
255259
)
256260
self.assertIsInstance(target_ds, xr.Dataset)
257261
self.assertEqual(

test/core/resampling/test_spatial.py

+5-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,11 @@ def test_affine_transform_dataset(self):
2525
)
2626

2727
target_ds = resample_in_space(
28-
source_ds, source_gm, target_gm, encode_cf=True, gm_name="crs"
28+
source_ds,
29+
source_gm=source_gm,
30+
target_gm=target_gm,
31+
encode_cf=True,
32+
gm_name="crs",
2933
)
3034

3135
self.assertIn("crs", target_ds)

xcube/core/resampling/affine.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ def affine_transform_dataset(
110110
resampled_dataset.assign_coords(new_coords),
111111
target_gm,
112112
gm_name,
113-
target_ds,
113+
target_ds.coords if target_ds else None,
114114
)
115115

116116

xcube/core/resampling/rectify.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ def rectify_dataset(
201201
xr.Dataset(dst_vars, coords=dst_ds_coords, attrs=src_attrs),
202202
target_gm,
203203
gm_name,
204-
target_ds,
204+
target_ds.coords if target_ds else None,
205205
)
206206

207207

0 commit comments

Comments
 (0)