File tree 2 files changed +13
-0
lines changed
2 files changed +13
-0
lines changed Original file line number Diff line number Diff line change 19
19
20
20
### Other
21
21
22
+ * Intermediate: Added important TODO, should be made a GH issue after 0.13.
23
+
22
24
* Removed deprecated example ` examples/tile ` .
23
25
24
26
## Changes in 0.13.0.dev10
Original file line number Diff line number Diff line change @@ -427,6 +427,17 @@ def url_for_path(self,
427
427
query : Optional [str ] = None ,
428
428
reverse : bool = False ) -> str :
429
429
"""Get the reverse URL for given *path* and *query*."""
430
+
431
+ # TODO (forman): in some cases, e.g.,
432
+ # when running a tornado server (such as xcube server)
433
+ # next to a remote Jupyter Server,
434
+ # the URL reported by this implementation is wrong.
435
+ # For example with reverse prefix "/proxy/8000", we expect
436
+ # https://{host}/users/{user}/proxy/8000/{path}
437
+ # but we get
438
+ # http://{host}/proxy/8000/{path}
439
+ # Also note, that protocol degraded from HTTPS to HTTP!
440
+ #
430
441
protocol = self ._request .protocol
431
442
host = self ._request .host
432
443
prefix = self ._reverse_url_prefix if reverse else self ._url_prefix
You can’t perform that action at this time.
0 commit comments