Skip to content

Commit 1a568b5

Browse files
committed
Added important TODO, should be made a GH issue after 0.13
1 parent 895df3d commit 1a568b5

File tree

2 files changed

+13
-0
lines changed

2 files changed

+13
-0
lines changed

CHANGES.md

+2
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@
1919

2020
### Other
2121

22+
* Intermediate: Added important TODO, should be made a GH issue after 0.13.
23+
2224
* Removed deprecated example `examples/tile`.
2325

2426
## Changes in 0.13.0.dev10

xcube/server/webservers/tornado.py

+11
Original file line numberDiff line numberDiff line change
@@ -427,6 +427,17 @@ def url_for_path(self,
427427
query: Optional[str] = None,
428428
reverse: bool = False) -> str:
429429
"""Get the reverse URL for given *path* and *query*."""
430+
431+
# TODO (forman): in some cases, e.g.,
432+
# when running a tornado server (such as xcube server)
433+
# next to a remote Jupyter Server,
434+
# the URL reported by this implementation is wrong.
435+
# For example with reverse prefix "/proxy/8000", we expect
436+
# https://{host}/users/{user}/proxy/8000/{path}
437+
# but we get
438+
# http://{host}/proxy/8000/{path}
439+
# Also note, that protocol degraded from HTTPS to HTTP!
440+
#
430441
protocol = self._request.protocol
431442
host = self._request.host
432443
prefix = self._reverse_url_prefix if reverse else self._url_prefix

0 commit comments

Comments
 (0)