fix sonarqube issues - unused imports, complexity, stringification

Author: xcutiboo

src/components/forms/advanced-form/advanced-form.component.ts

@@ -1,7 +1,6 @@
 import { Component, computed, inject, signal } from '@angular/core';
 import { CommonModule } from '@angular/common';
 import { FormsModule } from '@angular/forms';
-import { KittyAdvancedConfig } from '../../../models/kitty-types';
 import { NumberInputComponent } from '../../shared/number-input/number-input.component';
 import { VersionBadgeComponent } from '../../shared/version-badge/version-badge.component';
 import { createFormHelper } from '../../../utils/form-helpers';

src/components/forms/bell-form/bell-form.component.ts

@@ -1,7 +1,6 @@
 import { Component, computed, inject } from '@angular/core';
 import { CommonModule } from '@angular/common';
 import { FormsModule } from '@angular/forms';
-import { KittyBellConfig } from '../../../models/kitty-types';
 import { NumberInputComponent } from '../../shared/number-input/number-input.component';
 import { ColorInputComponent } from '../../shared/color-input/color-input.component';
 import { VersionBadgeComponent } from '../../shared/version-badge/version-badge.component';

src/components/forms/fonts-form/fonts-form.component.ts

@@ -2,7 +2,6 @@ import { Component, computed, inject } from '@angular/core';
 import { CommonModule } from '@angular/common';
 import { FormsModule } from '@angular/forms';
 import { FontPresetsService } from '../../../services/font-presets.service';
-import { KittyFontsConfig } from '../../../models/kitty-types';
 import { NumberInputComponent } from '../../shared/number-input/number-input.component';
 import { VersionBadgeComponent } from '../../shared/version-badge/version-badge.component';
 import { SliderInputComponent } from '../../shared/slider-input/slider-input.component';
@@ -358,7 +357,7 @@ export class FontsFormComponent {
   }
 
   setBoxDrawingScale(value: string): void {
-    const scale = value.split(',').map(s => parseFloat(s.trim())).filter(n => !isNaN(n));
+    const scale = value.split(',').map(s => Number.parseFloat(s.trim())).filter(n => !Number.isNaN(n));
     this.helper.updateField('box_drawing_scale', scale);
   }
 

src/components/forms/os-specific-form/os-specific-form.component.ts

@@ -1,8 +1,6 @@
-import { Component } from '@angular/core';
+import { Component, inject } from '@angular/core';
 import { CommonModule } from '@angular/common';
 import { FormsModule } from '@angular/forms';
-import { KittyOSSpecificConfig } from '../../../models/kitty-types';
-import { VersionBadgeComponent } from '../../shared/version-badge/version-badge.component';
 import { SliderInputComponent } from '../../shared/slider-input/slider-input.component';
 import { NumberInputComponent } from '../../shared/number-input/number-input.component';
 import { createFormHelper } from '../../../utils/form-helpers';

src/components/forms/performance-form/performance-form.component.ts

@@ -1,14 +1,11 @@
-import { Component } from '@angular/core';
+import { Component, inject } from '@angular/core';
 import { CommonModule } from '@angular/common';
-import { FormsModule } from '@angular/forms';
-import { KittyPerformanceConfig } from '../../../models/kitty-types';
-import { NumberInputComponent } from '../../shared/number-input/number-input.component';
 import { SliderInputComponent } from '../../shared/slider-input/slider-input.component';
 import { createFormHelper } from '../../../utils/form-helpers';
 
 @Component({
   selector: 'app-performance-form',
-  imports: [CommonModule, FormsModule, SliderInputComponent],
+  imports: [CommonModule, SliderInputComponent],
   template: `
     <div class="space-y-6">
       <div>

src/components/forms/scrollback-form/scrollback-form.component.ts

@@ -1,7 +1,6 @@
 import { Component, computed, inject } from '@angular/core';
 import { CommonModule } from '@angular/common';
 import { FormsModule } from '@angular/forms';
-import { KittyScrollbackConfig } from '../../../models/kitty-types';
 import { NumberInputComponent } from '../../shared/number-input/number-input.component';
 import { VersionBadgeComponent } from '../../shared/version-badge/version-badge.component';
 import { SliderInputComponent } from '../../shared/slider-input/slider-input.component';

src/components/forms/tab-bar-form/tab-bar-form.component.ts

@@ -1,7 +1,7 @@
 import { Component, computed, inject } from '@angular/core';
 import { CommonModule } from '@angular/common';
 import { FormsModule } from '@angular/forms';
-import { KittyTabBarConfig, KittyTabBarEdge } from '../../../models/kitty-types';
+import { KittyTabBarEdge } from '../../../models/kitty-types';
 import { NumberInputComponent } from '../../shared/number-input/number-input.component';
 import { VersionBadgeComponent } from '../../shared/version-badge/version-badge.component';
 import { createFormHelper } from '../../../utils/form-helpers';

src/components/forms/window-layout-form/window-layout-form.component.ts

@@ -1,7 +1,7 @@
 import { Component, computed, inject } from '@angular/core';
 import { CommonModule } from '@angular/common';
 import { FormsModule } from '@angular/forms';
-import { KittyWindowLayoutConfig, KittyLayout } from '../../../models/kitty-types';
+import { KittyLayout } from '../../../models/kitty-types';
 import { NumberInputComponent } from '../../shared/number-input/number-input.component';
 import { VersionBadgeComponent } from '../../shared/version-badge/version-badge.component';
 import { SliderInputComponent } from '../../shared/slider-input/slider-input.component';

src/components/live-preview/terminal-window.component.ts

@@ -216,6 +216,21 @@ export class TerminalWindowComponent {
   cursorBlinking = computed(() => this.cursorCfg().cursor_blink_interval !== 0);
   urlColor = computed(() => this.mouseCfg().url_color || this.colors().color4 || '#0087bd');
 
-  private parseBorderWidth(val: string): string { if (!val || val === '0' || val === '0pt' || val === '0px') return '0px'; if (val.endsWith('pt')) { const n = Number.parseFloat(val); return `${Math.max(0, Math.round(n * 1.333))}px`; } return val.endsWith('px') ? val : '1px'; }
-  private darken(hex: string, amount: number): string { if (!hex?.startsWith('#')) return '#333'; const c = hex.slice(1); if (c.length !== 6) return hex; const r = Math.max(0, Math.min(255, Number.parseInt(c.slice(0, 2), 16) - amount)); const g = Math.max(0, Math.min(255, Number.parseInt(c.slice(2, 4), 16) - amount)); const b = Math.max(0, Math.min(255, Number.parseInt(c.slice(4, 6), 16) - amount)); return `#${r.toString(16).padStart(2,'0')}${g.toString(16).padStart(2,'0')}${b.toString(16).padStart(2,'0')}`; }
+  private parseBorderWidth(val: string): string {
+    if (!val || val === '0' || val === '0pt' || val === '0px') return '0px';
+    if (val.endsWith('pt')) {
+      const n = Number.parseFloat(val);
+      return `${Math.max(0, Math.round(n * 1.333))}px`;
+    }
+    return val.endsWith('px') ? val : '1px';
+  }
+  private darken(hex: string, amount: number): string {
+    if (!hex?.startsWith('#')) return '#333';
+    const c = hex.slice(1);
+    if (c.length !== 6) return hex;
+    const r = Math.max(0, Math.min(255, Number.parseInt(c.slice(0, 2), 16) - amount));
+    const g = Math.max(0, Math.min(255, Number.parseInt(c.slice(2, 4), 16) - amount));
+    const b = Math.max(0, Math.min(255, Number.parseInt(c.slice(4, 6), 16) - amount));
+    return `#${r.toString(16).padStart(2,'0')}${g.toString(16).padStart(2,'0')}${b.toString(16).padStart(2,'0')}`;
+  }
 }

src/index.html

@@ -57,10 +57,6 @@
   <!-- PWA -->
   <link rel="manifest" href="/manifest.json" />
   <meta name="mobile-web-app-capable" content="yes" />
-  
-  <!-- Verification (add your own) -->
-  <!-- <meta name="google-site-verification" content="YOUR_CODE" /> -->
-  <!-- <meta name="msvalidate.01" content="YOUR_CODE" /> -->
     <script>
       (function () {
         var saved = localStorage.getItem('confitty-theme');