Size: don't subtract an external toolbar's height from the workplace

When the toolbar option points to an element outside the editor container,
__getNotWorkHeight still counted the toolbar height, so the workplace was
shrunk by a toolbar that wasn't in the container. Only subtract it when the
toolbar actually lives inside the container.

Fixes #920

Author: eric-mallac

CHANGELOG.md

@@ -9,6 +9,12 @@
 > - :house: [Internal]
 > - :nail_care: [Polish]
 
+## 4.12.32
+
+#### :bug: Bug Fix
+
+- **Editor size / external toolbar**: when the `toolbar` option points to an external element (the toolbar renders outside the editor container), the workplace height was still computed as `container height − toolbar height`, so the editing area was wrongly shrunk by the height of a toolbar that wasn't inside the container. The toolbar height is now subtracted only when the toolbar actually lives inside the container. Reported in [#920](https://github.com/xdan/jodit/discussions/920).
+
 ## 4.12.31
 
 #### :bug: Bug Fix

src/plugins/size/size.test.js

@@ -19,6 +19,24 @@
 			).equals(1);
 		});
 
+		// https://github.com/xdan/jodit/discussions/920
+		it('should not subtract an external toolbar height from the workplace (#920)', function () {
+			const toolbarBox = appendTestDiv();
+			const editor = getJodit({
+				toolbar: toolbarBox,
+				height: 400
+			});
+
+			const statusbarH = editor.statusbar.getHeight();
+
+			// The toolbar lives outside the container, so the workplace should
+			// fill the container minus only the statusbar — it must not be
+			// shrunk by the (external) toolbar's height.
+			expect(editor.workplace.offsetHeight).is.least(
+				editor.container.offsetHeight - statusbarH - 5
+			);
+		});
+
 		it('should show resize handler with custom buttons and counters disabled (issue #1335)', function () {
 			const editor = getJodit({
 				controls: {

src/plugins/size/size.ts

@@ -144,11 +144,18 @@ export class size extends Plugin {
 	 * Returns service spaces: toolbar + statusbar
 	 */
 	private __getNotWorkHeight(): number {
-		return (
-			(this.j.toolbarContainer?.offsetHeight || 0) +
-			(this.j.statusbar?.getHeight() || 0) +
-			2
-		);
+		// Only a toolbar that actually lives inside the editor container takes
+		// space away from the workplace. When the `toolbar` option points to an
+		// external element, the toolbar is rendered outside the container, so it
+		// must not be subtracted — otherwise the workplace is wrongly shrunk by
+		// the toolbar's height. See https://github.com/xdan/jodit/discussions/920
+		const toolbar = this.j.toolbarContainer;
+		const toolbarHeight =
+			toolbar && this.j.container.contains(toolbar)
+				? toolbar.offsetHeight
+				: 0;
+
+		return toolbarHeight + (this.j.statusbar?.getHeight() || 0) + 2;
 	}
 
 	/**