Skip to content

Commit f817939

Browse files
committed
test(delete): regression — deleting a selected image must not throw
'Node element must be in editor' was thrown on Delete/Backspace over a selected image in older versions (jodit-react#226); pin the fixed behaviour for both keys.
1 parent e3822fb commit f817939

1 file changed

Lines changed: 19 additions & 0 deletions

File tree

src/plugins/delete/delete.test.js

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,4 +39,23 @@ describe('Delete plugin', () => {
3939
});
4040
});
4141
});
42+
43+
describe('Remove selected image by keyboard', () => {
44+
// https://github.com/jodit/jodit-react/issues/226
45+
[Jodit.KEY_DELETE, Jodit.KEY_BACKSPACE].forEach(key => {
46+
it(`Should remove the image without throwing on ${key}`, () => {
47+
const editor = getJodit();
48+
editor.value =
49+
'<p>text <img src="tests/artio.jpg" alt=""> tail</p>';
50+
51+
const img = editor.editor.querySelector('img');
52+
editor.s.select(img);
53+
54+
simulateEvent('keydown', key, editor.editor);
55+
56+
expect(editor.editor.querySelector('img')).is.null;
57+
expect(editor.value.includes('text')).is.true;
58+
});
59+
});
60+
});
4261
});

0 commit comments

Comments
 (0)