Fix PMD / CheckStyle

Author: AB-xdev

eclipse-store-afs-ibm-cos-demo/src/main/java/software/xdev/Application.java

@@ -37,17 +37,17 @@ public final class Application
 	 */
 	public static void main(final String[] args)
 	{
-		final List<String> stringList = new ArrayList<>();
-		LOG.info("List size before loading: {}", stringList.size());
-		try(final EmbeddedStorageManager manager = getStorageManager(stringList))
+		final List<String> testData = new ArrayList<>();
+		LOG.info("List size before loading: {}", testData.size());
+		try(final EmbeddedStorageManager manager = getStorageManager(testData))
 		{
-			LOG.info("List size after loading: {}", stringList.size());
+			LOG.info("List size after loading: {}", testData.size());
 			for(int i = 0; i < 1_000_000; i++)
 			{
-				stringList.add("Test" + i);
+				testData.add("Test" + i);
 			}
-			manager.store(stringList);
-			LOG.info("List size after storing new entities: {}", stringList.size());
+			manager.store(testData);
+			LOG.info("List size after storing new entities: {}", testData.size());
 		}
 	}
 

eclipse-store-afs-ibm-cos-demo/src/main/java/software/xdev/ApplicationWithSingleAccess.java

@@ -42,20 +42,20 @@ public static void main(final String[] args)
 			client))
 		{
 			accessManager.waitForAndReserveSingleAccess();
-			final List<String> stringList = new ArrayList<>();
+			final List<String> testData = new ArrayList<>();
 			final long pid = ProcessHandle.current().pid();
 			LOG.info("Process ID: {}", pid);
-			try(final EmbeddedStorageManager storageManager = getStorageManager(stringList, client))
+			try(final EmbeddedStorageManager storageManager = getStorageManager(testData, client))
 			{
-				LOG.info("List size after loading: {}", stringList.size());
+				LOG.info("List size after loading: {}", testData.size());
 				accessManager.shutdownStorageWhenAccessShouldTerminate(storageManager);
 				int i = 0;
 				while(true)
 				{
 					i++;
 					final String newData = String.format("Number %d written by client with pid %d", i, pid);
-					stringList.add(newData);
-					storageManager.store(stringList);
+					testData.add(newData);
+					storageManager.store(testData);
 					LOG.info("Wrote new Data: {}", newData);
 				}
 			}

eclipse-store-afs-ibm-cos-demo/src/main/java/software/xdev/ApplicationWithSingleAccessReadOnly.java

@@ -49,7 +49,7 @@ public static void main(final String[] args)
 			client))
 		{
 			accessManager.waitForAndReserveSingleAccess();
-			final List<String> stringList = new ArrayList<>();
+			final List<String> testData = new ArrayList<>();
 			final long pid = ProcessHandle.current().pid();
 			LOG.info("Process ID: {}", pid);
 
@@ -70,18 +70,18 @@ public static void main(final String[] args)
 					.createConfiguration()
 			);
 
-			try(final EmbeddedStorageManager storageManager = foundation.createEmbeddedStorageManager(stringList))
+			try(final EmbeddedStorageManager storageManager = foundation.createEmbeddedStorageManager(testData))
 			{
 				storageManager.start();
-				LOG.info("List size after loading: {}", stringList.size());
+				LOG.info("List size after loading: {}", testData.size());
 				accessManager.setStorageToReadOnlyWhenAccessShouldTerminated(storageWriteController);
 				int i = 0;
 				while(true)
 				{
 					i++;
 					final String newData = String.format("Number %d written by client %d", i, pid);
-					stringList.add(newData);
-					storageManager.store(stringList);
+					testData.add(newData);
+					storageManager.store(testData);
 					LOG.info("Wrote new Data: {}", newData);
 				}
 			}

eclipse-store-afs-ibm-cos/src/main/java/software/xdev/eclipse/store/afs/ibm/CosClientCreator.java

@@ -15,8 +15,6 @@
  */
 package software.xdev.eclipse.store.afs.ibm;
 
-import java.util.Optional;
-
 import org.eclipse.serializer.configuration.exceptions.ConfigurationException;
 import org.eclipse.serializer.configuration.types.Configuration;
 
@@ -54,19 +52,10 @@ private static void configureClient(
 	)
 	{
 		configuration.opt("endpoint-override").ifPresent(endpointOverride ->
-		{
-			final Optional<String> region = configuration.opt("region");
-			if(region.isPresent())
-			{
-				clientBuilder.setEndpointConfiguration(new AwsClientBuilder.EndpointConfiguration(
-					endpointOverride,
-					region.get()));
-			}
-			else
-			{
-				throw new ConfigurationException(configuration);
-			}
-		});
+			clientBuilder.setEndpointConfiguration(new AwsClientBuilder.EndpointConfiguration(
+				endpointOverride,
+				configuration.opt("region")
+					.orElseThrow(() -> new ConfigurationException(configuration)))));
 		configuration.opt("region").ifPresent(clientBuilder::setRegion);
 		configuration.opt("credentials.type").ifPresent(credentialsType ->
 		{

eclipse-store-afs-ibm-cos/src/test/java/software/xdev/eclipse/store/afs/ibm/access/SingleAccessManagerTest.java

@@ -32,7 +32,7 @@
 
 class SingleAccessManagerTest
 {
-	public static final int KEEP_ALIVE_INTERVAL_FOR_TOKEN = 100;
+	static final int KEEP_ALIVE_INTERVAL_FOR_TOKEN = 100;
 	private AccessConfiguration configuration;
 	private CosAccessCommunicatorLocal communicator;
 
@@ -48,7 +48,7 @@ void init()
 		this.communicator = new CosAccessCommunicatorLocal(this.configuration);
 	}
 
-	public SingleAccessManager createManager()
+	SingleAccessManager createManager()
 	{
 		return new SingleAccessManager(this.configuration, this.communicator);
 	}