update APIs

Author: superlopuh

asl_xdsl/dialects/asl.py

@@ -126,9 +126,11 @@ def _print_integer_constraint(
 ):
     """Print an integer constraint using a shorthand syntax."""
     if isinstance(constraint, ConstraintExactAttr):
-        printer.print(constraint.value)
+        printer.print_int(constraint.value)
     else:
-        printer.print(constraint.min_value, ":", constraint.max_value)
+        printer.print_int(constraint.min_value)
+        printer.print_string(":")
+        printer.print_int(constraint.max_value)
 
 
 @irdl_attr_definition
@@ -334,9 +336,10 @@ def parse(cls, parser: Parser) -> ConstantIntOp:
 
     def print(self, printer: Printer) -> None:
         """Print the operation."""
-        printer.print(" ", self.value.data)
+        printer.print_string(" ")
+        printer.print_int(self.value.data)
         if self.attributes:
-            printer.print(" ")
+            printer.print_string(" ")
             printer.print_attr_dict(self.attributes)
 
 
@@ -376,9 +379,12 @@ def parse(cls, parser: Parser) -> ConstantBitVectorOp:
 
     def print(self, printer: Printer) -> None:
         """Print the operation."""
-        printer.print(" ", self.value.value.data, " : ", self.res.type)
+        printer.print_string(" ")
+        printer.print_int(self.value.value.data)
+        printer.print_string(" : ")
+        printer.print_attribute(self.res.type)
         if self.attributes:
-            printer.print(" ")
+            printer.print_string(" ")
             printer.print_attr_dict(self.attributes)
 
 

asl_xdsl/dialects/asl_dep.py

@@ -101,9 +101,10 @@ def parse(cls, parser: Parser) -> ConstantIntOp:
 
     def print(self, printer: Printer) -> None:
         """Print the operation."""
-        printer.print(" ", self.value_attr.data)
+        printer.print_string(" ")
+        printer.print_int(self.value_attr.data)
         if self.attributes:
-            printer.print(" ")
+            printer.print_string(" ")
             printer.print_attr_dict(self.attributes)
 
 
@@ -144,9 +145,13 @@ def parse(cls, parser: Parser) -> ConstantBitsOp:
         return op
 
     def print(self, printer: Printer) -> None:
-        printer.print(" ", self.value_attr.data, " : bits<", self.value_width, ">")
+        printer.print_string(" ")
+        printer.print_int(self.value_attr.data)
+        printer.print_string(" : bits<")
+        printer.print_ssa_value(self.value_width)
+        printer.print_string(">")
         if self.attributes:
-            printer.print(" ")
+            printer.print_string(" ")
             printer.print_attr_dict(self.attributes)
 
 

asl_xdsl/interpreters/asl.py

@@ -15,6 +15,7 @@
 )
 from xdsl.ir import Operation
 from xdsl.utils.comparisons import to_signed, to_unsigned
+from xdsl.utils.hints import isa
 
 from asl_xdsl.dialects import asl
 
@@ -541,7 +542,7 @@ def asl_print_bits_hex(
     def asl_print_sintN_hex(
         self, interpreter: Interpreter, op: asl.PrintSIntNHexOp, args: PythonValues
     ) -> PythonValues:
-        assert isinstance(op.arg.type, builtin.IntegerType)
+        assert isa(op.arg.type, builtin.IntegerType)
         width = op.arg.type.width.data
         arg: int
         (arg,) = args
@@ -556,7 +557,7 @@ def asl_print_sintN_hex(
     def asl_print_sintN_dec(
         self, interpreter: Interpreter, op: asl.PrintSIntNDecOp, args: PythonValues
     ) -> PythonValues:
-        assert isinstance(op.arg.type, builtin.IntegerType)
+        assert isa(op.arg.type, builtin.IntegerType)
         width = op.arg.type.width.data
         arg: int
         (arg,) = args

tests/filecheck/analysis/test-integer-range-analysis.mlir

@@ -2,12 +2,12 @@
 
 builtin.module {
 
-    // CHECK: %unknown = "test.op"() {__integer_ranges = {{[}}[#none, #none]]} : () -> !asl.int
+    // CHECK: %unknown = "test.op"() {__integer_ranges = {{[}}[none, none]]} : () -> !asl.int
     %unknown = "test.op"() : () -> !asl.int
-    
+
     // CHECK-NEXT: %cst16 = asl.constant_int 16 {__integer_ranges = {{[}}[#builtin.int<16>, #builtin.int<16>]]}
     %cst16 = asl.constant_int 16
-    
+
     // CHECK-NEXT: %res = asl.mod_pow2_int %unknown, %cst16 : (!asl.int, !asl.int) -> !asl.int {__integer_ranges = {{[}}[#builtin.int<0>, #builtin.int<65535>]]}
     %res = asl.mod_pow2_int %unknown, %cst16 : (!asl.int, !asl.int) -> !asl.int
 }