Merge pull request #194 from xendit/feat/bump-to-support-php84

feat: magento module support php8.4

Author: seanyu4296

CHANGELOG.md

@@ -1,4 +1,8 @@
 # CHANGELOG
+
+## 12.1.1 (2025-10-08)
+- support php 8.4
+
 ## 12.1.0 (2025-10-08)
 - single xendit button for checkout
 - cleanup cc and cc subscriptions and promo
@@ -75,7 +79,7 @@ Features:
 - Add new IDR payment Akulaku
 
 Improvements:
-- Webhook update order status improvements 
+- Webhook update order status improvements
 
 ## 4.0.1 (2022-08-01)
 Improvements:

DEV.md

@@ -4,17 +4,17 @@
 
 ## 1. Machine Setup
 1. Use Mac with Silicon
-2. Install `php@8.3`
-   1. Run `brew install php@8.3`
+2. Install `php@8.4`
+   1. Run `brew install php@8.4`
    2. Bonus: `brew install brew-php-switcher` for easy php version switching
 3. Use `orbstack` for running docker containers
-   1. Why? because `webdevops/php-apache-dev:8.3` doesn't work on ARM64 because of its apached ssl failing. [see this issue](https://github.com/webdevops/Dockerfile/issues/433). Weirdly, testing in orbstack works.
+   1. Why? because `webdevops/php-apache-dev:8.4` doesn't work on ARM64 because of its apached ssl failing. [see this issue](https://github.com/webdevops/Dockerfile/issues/433). Weirdly, testing in orbstack works.
    2. Run `brew install orbstack`
    3. Run `Orbstack` in Application
 ## 2. Local Magento2.4 Setup w/ Xendit Module
 1. Clone `magento2` in `./docker-magento/`
    1. Run `git clone https://github.com/magento/magento2.git`
-   2. `git checkout 2.4`
+   2. `git checkout 2.4.8`
    3. This will take some time
 2. Add local domain
    1. Why? this is needed to match the `base-url-secure` later on magento installation.
@@ -127,7 +127,7 @@ php bin/magento setup:install \
 --admin-use-security-key=1 \
 --session-save=files \
 --use-sample-data \
---search-engine=elasticsearch7 \
+--search-engine=elasticsearch8 \
 --elasticsearch-host=elasticsearch \
 --elasticsearch-port=9200
 ```

Logger/Handler.php

@@ -6,6 +6,7 @@
 use Magento\Framework\Logger\Handler\Base;
 use Magento\Store\Model\ScopeInterface;
 use Monolog\Logger;
+use Monolog\LogRecord;
 
 /**
  * Class Handler
@@ -32,16 +33,17 @@ public function __construct(
     }
 
     /**
-     * @param array $record
+     * @param array|LogRecord $record
      * @return bool
      */
-    public function isHandling(array $record): bool
+    public function isHandling(array|LogRecord $record): bool
     {
         $isDebugEnabled = (bool)$this->scopeConfig->getValue("payment/xendit/debug", ScopeInterface::SCOPE_STORE);
         if ($isDebugEnabled) {
             return true;
         }
 
-        return $record['level'] >= \Monolog\Logger::WARNING;
+        $level = $record instanceof LogRecord ? $record->level->value : $record['level'];
+        return $level >= \Monolog\Logger::WARNING;
     }
 }

composer.json

@@ -7,7 +7,7 @@
     "GPL-3.0"
   ],
   "require": {
-    "php": "~7.1.3||~7.2.0||~7.3.0||~7.4.0||~8.1.0||~8.2.0||~8.3.0",
+    "php": "~7.1.3||~7.2.0||~7.3.0||~7.4.0||~8.1.0||~8.2.0||~8.3.0||~8.4.0",
     "magento/module-sales": ">=102.0.3",
     "magento/module-checkout": ">=100.3.3",
     "magento/module-payment": ">=100.3.3",

docker-magento/docker-compose.yml

@@ -1,7 +1,7 @@
 version: '3'
 services:
     web:
-        image: webdevops/php-apache-dev:8.3
+        image: webdevops/php-apache-dev:8.4
         container_name: web
         restart: always
         user: root
@@ -49,15 +49,17 @@ services:
         depends_on:
           - mysql
     elasticsearch:
-        image: docker.elastic.co/elasticsearch/elasticsearch:7.6.2
+        image: docker.elastic.co/elasticsearch/elasticsearch:8.11.3
         container_name: elasticsearch
         ports:
             - "9200:9200"
         environment:
             - discovery.type=single-node
-            - network.host=0.0.0.0  # Changed from localhost
+            - network.host=0.0.0.0
             - http.port=9200
             - cluster.name=elasticsearch
+            - xpack.security.enabled=false
+            - xpack.security.http.ssl.enabled=false
         volumes:
             - elasticsearch_data:/var/lib/elastisearch
 volumes: