feat: payment session checkout - #209
Merged
Merged
Conversation
…on, and integration notification controller
SAST - Quality Gate Passed
Please check this following page for the details : new changes result and overall result Dependency Chek Report
Please check this following page for the details : dependabot dashboard |
|
Plan Error |
…store payment_id in xendit_transaction_id
…tionForPaymentSession
…ce model expects 1/0)
… staging url revert
…nue on order failure, getState consistency, extract shared PS helpers, cache invalidation
yanoandri
reviewed
May 5, 2026
yanoandri
left a comment
yanoandri
left a comment
Contributor
There was a problem hiding this comment.
Generally good just a bit of improvement, what is left to do are
- Updating the composer.json to be 13.0.0
- Update the inside CHANGELOG.md
| private function handleNotification(array $payload) | ||
| { | ||
| // Validate required fields | ||
| if (empty($payload['_id']) || empty($payload['signature'])) { |
Contributor
There was a problem hiding this comment.
also add validation where magento_checkout_idempotency_key and magento_checkout_type if it's empty
Contributor
There was a problem hiding this comment.
hm might also add an isset too
yanoandri
approved these changes
May 6, 2026
yanoandri
left a comment
yanoandri
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but don't merge yet, please address https://github.com/xendit/xendit-magento-payment-module/pull/209/changes#r3187211884
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.