When delete game returns 404, it still deletes from isolated storage

Author: xenobiasoft

src/frontend/Sudoku.Blazor/Models/ApiResult.cs

@@ -10,6 +10,6 @@ public class ApiResult<T>
     public static ApiResult<T> Success(T value) =>
         new ApiResult<T> { IsSuccess = true, Value = value, StatusCode = 200 };
 
-    public static ApiResult<T> Failure(string error) =>
-        new ApiResult<T> { IsSuccess = false, Error = error };
+    public static ApiResult<T> Failure(string error, int statusCode = 0) =>
+        new ApiResult<T> { IsSuccess = false, Error = error, StatusCode = statusCode };
 }

src/frontend/Sudoku.Blazor/Services/GameStateManager.cs

@@ -58,7 +58,7 @@ public async Task DeleteGameAsync(string alias, string gameId)
             throw new ArgumentException("Game ID not set.");
         }
         var result = await gameApiClient.DeleteGameAsync(alias, gameId);
-        if (!result.IsSuccess)
+        if (!result.IsSuccess && result.StatusCode != 404)
         {
             throw new Exception("Failed to delete game from server.");
         }

src/frontend/Sudoku.Blazor/Services/HttpClients/GameApiClient.cs

@@ -216,7 +216,7 @@ public async Task<ApiResult<bool>> DeleteGameAsync(string alias, string gameId)
             {
                 var error = await response.Content.ReadAsStringAsync();
                 _logger.LogWarning("Failed to delete game. Status: {StatusCode}, Error: {Error}", response.StatusCode, error);
-                return ApiResult<bool>.Failure($"Failed to delete game: {error}");
+                return ApiResult<bool>.Failure($"Failed to delete game: {error}", (int)response.StatusCode);
             }
         }
         catch (Exception ex)

src/frontend/Sudoku.React/src/hooks/useGameService.ts

@@ -108,30 +108,31 @@ export function useGameService(): UseGameServiceReturn {
     try {
       // Delete from API
       await apiClient.deleteGame(playerAlias, gameId);
+    } catch (err) {
+      if (!(err instanceof Error) || !err.message.startsWith('HTTP 404')) {
+        const errorMessage = err instanceof Error ? err.message : 'Failed to delete game';
+        setError(errorMessage);
+        console.error('Failed to delete game:', err);
+        throw err;
+      }
+    }
 
-      // Update local state
-      setSavedGames(games => games.filter(g => g.id !== gameId));
-
-      // Clear current game if it's the one being deleted
-      setCurrentGame(current => current?.id === gameId ? null : current);
-
-      // Update localStorage cache
-      const cachedGames = localStorage.getItem('savedGames');
-      if (cachedGames) {
-        try {
-          const parsedGames: GameModel[] = JSON.parse(cachedGames);
-          const updatedGames = parsedGames.filter(g => g.id !== gameId);
-          localStorage.setItem('savedGames', JSON.stringify(updatedGames));
-        } catch {
-          // If cache is corrupted, just remove it
-          localStorage.removeItem('savedGames');
-        }
+    // Update local state (runs on success or 404 — game is gone either way)
+    setSavedGames(games => games.filter(g => g.id !== gameId));
+
+    // Clear current game if it's the one being deleted
+    setCurrentGame(current => current?.id === gameId ? null : current);
+
+    // Update localStorage cache
+    const cachedGames = localStorage.getItem('savedGames');
+    if (cachedGames) {
+      try {
+        const parsedGames: GameModel[] = JSON.parse(cachedGames);
+        const updatedGames = parsedGames.filter(g => g.id !== gameId);
+        localStorage.setItem('savedGames', JSON.stringify(updatedGames));
+      } catch {
+        localStorage.removeItem('savedGames');
       }
-    } catch (err) {
-      const errorMessage = err instanceof Error ? err.message : 'Failed to delete game';
-      setError(errorMessage);
-      console.error('Failed to delete game:', err);
-      throw err; // Re-throw so calling component can handle it
     }
   }, [isLoading]);