xerox81
diff --git a/‎.gitignore‎
Lines changed: 7 additions & 0 deletions b/‎.gitignore‎
Lines changed: 7 additions & 0 deletions
diff --git a/‎backend/alembic/versions/20260401_fix_migration_history_cascade.py‎
Lines changed: 134 additions & 0 deletions b/‎backend/alembic/versions/20260401_fix_migration_history_cascade.py‎
Lines changed: 134 additions & 0 deletions
diff --git a/‎backend/alembic/versions/20260402_model_lifecycle_fields.py‎
Lines changed: 79 additions & 0 deletions b/‎backend/alembic/versions/20260402_model_lifecycle_fields.py‎
Lines changed: 79 additions & 0 deletions
diff --git a/‎backend/alembic/versions/20260403_add_migration_history_provider_types.py‎
Lines changed: 79 additions & 0 deletions b/‎backend/alembic/versions/20260403_add_migration_history_provider_types.py‎
Lines changed: 79 additions & 0 deletions
diff --git a/‎backend/alembic/versions/20260430_add_model_costs.py‎
Lines changed: 62 additions & 0 deletions b/‎backend/alembic/versions/20260430_add_model_costs.py‎
Lines changed: 62 additions & 0 deletions
@@ -28,6 +28,13 @@ backend/exports/
 # test results
 backend/test-results/
 
+# Local review notes and ad-hoc UI screenshots (not part of the codebase)
+REVIEW_*.md
+REVIEW_PLAN.md
+REVIEW_REPORT.md
+chat-*.png
+notes/
+
 # claude
 .claude/*.local.json
 backend/openapi.json
 
@@ -0,0 +1,134 @@
+"""fix migration history cascade and add model names
+
+Store model names directly in migration history so records survive
+model deletion. Change FK ondelete from CASCADE to SET NULL.
+
+Revision ID: fix_migration_history
+Revises: 20260319_add_nickname
+Create Date: 2026-04-01
+
+"""
+from alembic import op
+import sqlalchemy as sa
+
+# revision identifiers, used by Alembic
+revision = "fix_migration_history"
+down_revision = "20260319_add_nickname"
+branch_labels = None
+depends_on = None
+
+
+def upgrade() -> None:
+    # Add name columns to store model names directly
+    op.add_column(
+        "completion_model_migration_history",
+        sa.Column("from_model_name", sa.String(255), nullable=True),
+    )
+    op.add_column(
+        "completion_model_migration_history",
+        sa.Column("to_model_name", sa.String(255), nullable=True),
+    )
+
+    # Backfill names from existing model data
+    op.execute("""
+        UPDATE completion_model_migration_history h
+        SET from_model_name = m.name
+        FROM completion_models m
+        WHERE h.from_model_id = m.id AND h.from_model_name IS NULL
+    """)
+    op.execute("""
+        UPDATE completion_model_migration_history h
+        SET to_model_name = m.name
+        FROM completion_models m
+        WHERE h.to_model_id = m.id AND h.to_model_name IS NULL
+    """)
+
+    # Drop old FK constraints with CASCADE
+    op.drop_constraint(
+        "completion_model_migration_history_from_model_id_fkey",
+        "completion_model_migration_history",
+        type_="foreignkey",
+    )
+    op.drop_constraint(
+        "completion_model_migration_history_to_model_id_fkey",
+        "completion_model_migration_history",
+        type_="foreignkey",
+    )
+
+    # Make model ID columns nullable (model may be deleted)
+    op.alter_column(
+        "completion_model_migration_history",
+        "from_model_id",
+        nullable=True,
+    )
+    op.alter_column(
+        "completion_model_migration_history",
+        "to_model_id",
+        nullable=True,
+    )
+
+    # Re-create FK constraints with SET NULL
+    op.create_foreign_key(
+        "completion_model_migration_history_from_model_id_fkey",
+        "completion_model_migration_history",
+        "completion_models",
+        ["from_model_id"],
+        ["id"],
+        ondelete="SET NULL",
+    )
+    op.create_foreign_key(
+        "completion_model_migration_history_to_model_id_fkey",
+        "completion_model_migration_history",
+        "completion_models",
+        ["to_model_id"],
+        ["id"],
+        ondelete="SET NULL",
+    )
+
+
+def downgrade() -> None:
+    # Drop new FK constraints
+    op.drop_constraint(
+        "completion_model_migration_history_from_model_id_fkey",
+        "completion_model_migration_history",
+        type_="foreignkey",
+    )
+    op.drop_constraint(
+        "completion_model_migration_history_to_model_id_fkey",
+        "completion_model_migration_history",
+        type_="foreignkey",
+    )
+
+    # Make columns non-nullable again
+    op.alter_column(
+        "completion_model_migration_history",
+        "from_model_id",
+        nullable=False,
+    )
+    op.alter_column(
+        "completion_model_migration_history",
+        "to_model_id",
+        nullable=False,
+    )
+
+    # Re-create old FK constraints with CASCADE
+    op.create_foreign_key(
+        "completion_model_migration_history_from_model_id_fkey",
+        "completion_model_migration_history",
+        "completion_models",
+        ["from_model_id"],
+        ["id"],
+        ondelete="CASCADE",
+    )
+    op.create_foreign_key(
+        "completion_model_migration_history_to_model_id_fkey",
+        "completion_model_migration_history",
+        "completion_models",
+        ["to_model_id"],
+        ["id"],
+        ondelete="CASCADE",
+    )
+
+    # Drop name columns
+    op.drop_column("completion_model_migration_history", "to_model_name")
+    op.drop_column("completion_model_migration_history", "from_model_name")
@@ -0,0 +1,79 @@
+"""add model lifecycle fields for migration and soft-delete
+
+Add migrated_to_model_id and deleted_at to completion_models.
+Change questions.completion_model_id FK from SET NULL to RESTRICT
+to prevent silent loss of historical question attribution.
+
+Revision ID: 20260402_lifecycle
+Revises: fix_migration_history
+Create Date: 2026-04-02
+
+"""
+from alembic import op
+import sqlalchemy as sa
+from sqlalchemy.dialects.postgresql import UUID
+
+# revision identifiers, used by Alembic
+revision = "20260402_lifecycle"
+down_revision = "fix_migration_history"
+branch_labels = None
+depends_on = None
+
+
+def upgrade() -> None:
+    # 1. Add migrated_to_model_id (self-referencing FK with RESTRICT)
+    op.add_column(
+        "completion_models",
+        sa.Column("migrated_to_model_id", UUID(as_uuid=True), nullable=True),
+    )
+    op.create_foreign_key(
+        "fk_completion_models_migrated_to",
+        "completion_models",
+        "completion_models",
+        ["migrated_to_model_id"],
+        ["id"],
+        ondelete="RESTRICT",
+    )
+
+    # 2. Add deleted_at for soft-delete
+    op.add_column(
+        "completion_models",
+        sa.Column("deleted_at", sa.TIMESTAMP(timezone=True), nullable=True),
+    )
+
+    # 3. Change questions.completion_model_id FK from SET NULL to RESTRICT
+    op.drop_constraint(
+        "questions_completion_model_id_fkey", "questions", type_="foreignkey"
+    )
+    op.create_foreign_key(
+        "questions_completion_model_id_fkey",
+        "questions",
+        "completion_models",
+        ["completion_model_id"],
+        ["id"],
+        ondelete="RESTRICT",
+    )
+
+
+def downgrade() -> None:
+    # Revert questions FK to SET NULL
+    op.drop_constraint(
+        "questions_completion_model_id_fkey", "questions", type_="foreignkey"
+    )
+    op.create_foreign_key(
+        "questions_completion_model_id_fkey",
+        "questions",
+        "completion_models",
+        ["completion_model_id"],
+        ["id"],
+        ondelete="SET NULL",
+    )
+
+    # Remove deleted_at
+    op.drop_column("completion_models", "deleted_at")
+
+    # Remove migrated_to_model_id
+    op.drop_constraint(
+        "fk_completion_models_migrated_to", "completion_models", type_="foreignkey"
+    )
+    op.drop_column("completion_models", "migrated_to_model_id")
@@ -0,0 +1,79 @@
+"""add provider snapshots for migration history and lifecycle cleanup indexes
+
+Revision ID: 20260403_cleanup_history
+Revises: 20260402_lifecycle
+Create Date: 2026-04-03
+
+"""
+
+import sqlalchemy as sa
+
+from alembic import op
+
+# revision identifiers, used by Alembic.
+revision = "20260403_cleanup_history"
+down_revision = "20260402_lifecycle"
+branch_labels = None
+depends_on = None
+
+
+def upgrade() -> None:
+    op.add_column(
+        "completion_model_migration_history",
+        sa.Column("from_provider_type", sa.String(length=255), nullable=True),
+    )
+    op.add_column(
+        "completion_model_migration_history",
+        sa.Column("to_provider_type", sa.String(length=255), nullable=True),
+    )
+
+    op.execute(
+        """
+        UPDATE completion_model_migration_history AS history
+        SET from_provider_type = providers.provider_type
+        FROM completion_models AS models
+        LEFT JOIN model_providers AS providers ON models.provider_id = providers.id
+        WHERE history.from_model_id = models.id
+          AND history.from_provider_type IS NULL
+        """
+    )
+    op.execute(
+        """
+        UPDATE completion_model_migration_history AS history
+        SET to_provider_type = providers.provider_type
+        FROM completion_models AS models
+        LEFT JOIN model_providers AS providers ON models.provider_id = providers.id
+        WHERE history.to_model_id = models.id
+          AND history.to_provider_type IS NULL
+        """
+    )
+    # Build the new indexes without holding a table-level lock — on a large
+    # `completion_models` table the default CREATE INDEX would block writes
+    # for the duration of the build. See 202604221200 for the same pattern,
+    # including notes on INVALID-index recovery if CONCURRENTLY fails
+    # mid-build (Alembic still marks the migration applied).
+    with op.get_context().autocommit_block():
+        op.execute(
+            """
+            CREATE INDEX CONCURRENTLY IF NOT EXISTS ix_completion_models_deleted_at
+            ON completion_models (deleted_at);
+            """
+        )
+        op.execute(
+            """
+            CREATE INDEX CONCURRENTLY IF NOT EXISTS ix_completion_models_migrated_to_model_id
+            ON completion_models (migrated_to_model_id);
+            """
+        )
+
+
+def downgrade() -> None:
+    with op.get_context().autocommit_block():
+        op.execute(
+            "DROP INDEX CONCURRENTLY IF EXISTS ix_completion_models_migrated_to_model_id;"
+        )
+        op.execute(
+            "DROP INDEX CONCURRENTLY IF EXISTS ix_completion_models_deleted_at;"
+        )
+    op.drop_column("completion_model_migration_history", "to_provider_type")
+    op.drop_column("completion_model_migration_history", "from_provider_type")
@@ -0,0 +1,62 @@
+"""add input/output cost columns to model tables
+
+Adds optional USD cost columns so admins can record (and we can display) the
+indicative price of each model. Token-based costs are stored as `NUMERIC(20, 12)`
+to preserve precision down to fractions of a cent per token (modern frontier
+models are priced in 1e-7 USD/token territory).
+
+Token-based modes (chat/completion + embedding):
+  - input_cost_per_token
+  - output_cost_per_token
+
+Per-minute mode (transcription) gets its own column rather than reusing the
+token columns, since the underlying ratecard is structured differently:
+  - cost_per_minute
+
+All columns are nullable. Self-hosted/unknown providers are expected to leave
+them unset; the UI displays an em-dash and excludes the model from cost
+aggregation when any contributing rate is missing.
+
+This revision also merges the two parallel heads on the develop branch.
+
+Revision ID: 20260430_add_model_costs
+Revises: 202604291030, 20260403_cleanup_history
+Create Date: 2026-04-30 12:00:00.000000
+"""
+
+import sqlalchemy as sa
+
+from alembic import op
+
+# revision identifiers, used by Alembic
+revision = "20260430_add_model_costs"
+down_revision = ("202604291030", "20260403_cleanup_history")
+branch_labels = None
+depends_on = None
+
+
+def upgrade() -> None:
+    # Token-based cost on completion + embedding tables.
+    for table in ("completion_models", "embedding_models"):
+        op.add_column(
+            table,
+            sa.Column("input_cost_per_token", sa.Numeric(20, 12), nullable=True),
+        )
+        op.add_column(
+            table,
+            sa.Column("output_cost_per_token", sa.Numeric(20, 12), nullable=True),
+        )
+
+    # Transcription is priced per minute of audio. Six decimals is enough for
+    # any provider we've seen (Whisper is 0.006 USD/min).
+    op.add_column(
+        "transcription_models",
+        sa.Column("cost_per_minute", sa.Numeric(20, 6), nullable=True),
+    )
+
+
+def downgrade() -> None:
+    op.drop_column("transcription_models", "cost_per_minute")
+    for table in ("completion_models", "embedding_models"):
+        op.drop_column(table, "output_cost_per_token")
+        op.drop_column(table, "input_cost_per_token")