Skip to content

Commit 7052d6f

Browse files
committed
Fix Store.getFieldValues() to include null values in returned set (#4307)
Previously, `getFieldValues()` silently excluded null/undefined values, preventing grid column filters from offering a [blank] option. Inverted the nil check so null is added to the result set.
1 parent 37f37c0 commit 7052d6f

2 files changed

Lines changed: 14 additions & 6 deletions

File tree

CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,13 @@
11
# Changelog
22

3+
## 82.0.4 - 2026-03-23
4+
5+
### 🐞 Bug Fixes
6+
7+
* Fixed `Store.getFieldValues()` to include `null` in its returned set when records contain
8+
null/undefined values. Previously these were silently excluded, preventing grid column filters
9+
from offering a [blank] option.
10+
311
## 82.0.3 - 2026-03-02
412

513
### 🐞 Bug Fixes

data/Store.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -849,12 +849,12 @@ export class Store
849849
const ret = new Set();
850850
recs.forEach(rec => {
851851
const val = rec.get(fieldName);
852-
if (!isNil(val)) {
853-
if (field.type === 'tags') {
854-
val.forEach(it => ret.add(it));
855-
} else {
856-
ret.add(val);
857-
}
852+
if (isNil(val)) {
853+
ret.add(null);
854+
} else if (field.type === 'tags') {
855+
val.forEach(it => ret.add(it));
856+
} else {
857+
ret.add(val);
858858
}
859859
});
860860

0 commit comments

Comments
 (0)