-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review / simplify FileChooser
based on real-world usage
#3527
Labels
Comments
I'd propose the following mildly-breaking (but not in a bad way) API changes:
|
react-dropzone/react-dropzone#752 points to adding reasons for file rejection in the FileRejection object that onDrop and onDropRejected (of React Dropzone) take in react-dropzone version 11.0.0. |
6 tasks
amcclain
changed the title
Review / simplify Jun 25, 2024
FileChooser
should provide full control over targetText/rejectTextFileChooser
based on real-world usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expanding ticket to more general review of this comp and the various apps where we decided not to use it and had to roll our own.
The
FileChooser
component accepts atargetText
prop, but always shows its own text when actively hovering over the target. It does not provide any control over the text displayed when a drop is rejected.hoist-react/desktop/cmp/filechooser/FileChooser.ts
Line 93 in 9538b51
We have a usage in a client app where we are showing the target in a tightly-managed layout and want the ability to customize both.
The text was updated successfully, but these errors were encountered: