Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider logging exceptions caught by LoadSupport #3787

Open
ghsolomon opened this issue Sep 13, 2024 · 0 comments
Open

Consider logging exceptions caught by LoadSupport #3787

ghsolomon opened this issue Sep 13, 2024 · 0 comments

Comments

@ghsolomon
Copy link
Contributor

LoadSupport.doLoadAsync catches exceptions thrown by HoistModel.doLoadAsync and updates its lastLoadException observable accordingly. It also includes the exception in the browser console log, at an appropriate log-level. However, it does not log these exceptions on the server.

Consider logging exceptions not marked as routine and not thrown on autoRefresh to the server so they are reported.

Alternatively, app developers should be encouraged to catch and handle exceptions themselves, but our current story is that LoadSupport will only know about uncaught exceptions (or exceptions that are caught, handled, and rethrown).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant