Skip to content

XH.reloadApp() should strip query params #3920

Open
@amcclain

Description

For consideration - should our reloadApp method remove query params? See below, where an auth error left an Auth0 code param in the URL, which now will always throw an invalid state error out of the Auth0 library. Clicking "reload" option in exception dialog refreshes page with same param in place, failing to resolve the issue or try again.

Image

It seems like it would be generally safer to remove query params, or have an option to do so and turn that option on for the reload usage from the exception handler.

Note that reloadApp currently installs an xhCacheBuster param to ensure the browser reloads the page - with this change, that param would replace any existing params.

(We could also look more at the specific issue with a bad auth0 code param throwing this particular error - but wanted to get this more general case into a ticket.)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions