Bump to React 19 (deps + peer range)#4417
Draft
lbwexler wants to merge 2 commits into
Draft
Conversation
Moves the @types/react@19 code fixes (the non-dependency portion of the React 19 upgrade) onto this prep branch, since all are forward-compatible - they compile and lint clean under @types/react@18 and behave identically on React 18: - useRef<HTMLDivElement>(null) explicit initial arg (DynamicTabSwitcher) - cast element props access, now 'unknown' under @types 19 (DashCanvasWidgetChooser) - type cloneElement child as ReactElement<any> (UseHotkeys, UseContextMenu) - wrap async ref handler to return void (CodeInput) - narrow render-fn results to ReactElement (Column editor, Scroller content) Verified: tsc + eslint clean under @types/react@18.
Bumps react/react-dom (dev) and @types/react/@types/react-dom to 19, widens the react/react-dom peer range to '~18.2.0 || ^19.0.0', and notes React 19 support in the changelog. The forward-compatible code fixes this upgrade requires now live on the react-19 prep branch (this branch is stacked on it), so this commit is the dependency bump alone. tsc clean under @types/react@19.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on the
react-19prep branch. Completes the React 19 upgrade with the dependency bump and peer-range widening.Changes
react/react-dom(dev) and@types/react/@types/react-domto 19.react/react-dompeer range to~18.2.0 || ^19.0.0.@types/react@19type-prep fixes (all compile and lint clean under@types/react@18and behave identically on React 18):useRef<HTMLDivElement>(null)explicit initial arg (DynamicTabSwitcher)unknownunder@types19 (DashCanvasWidgetChooser)cloneElementchild asReactElement<any>(UseHotkeys,UseContextMenu)CodeInput)ReactElement(Columneditor,Scrollercontent)Verified:
tsc+eslintclean under both@types/react@18and@types/react@19.