Support for new XH.openInTab (#761)

Author: lbwexler

client-app/src/admin/tests/fetch/TabPanels.ts

@@ -1,4 +1,4 @@
-import {hoistCmp} from '@xh/hoist/core';
+import {hoistCmp, XH} from '@xh/hoist/core';
 import {Icon} from '@xh/hoist/icon';
 import {hframe, vframe} from '@xh/hoist/cmp/layout';
 import {button} from '@xh/hoist/desktop/cmp/button';
@@ -23,7 +23,7 @@ export const individualBtns = hoistCmp.factory<FetchApiTestModel>(({model}) =>
                     }),
                     button({
                         icon: Icon.info(),
-                        onClick: () => window.open(`${model.referenceSite}${it.code}`),
+                        onClick: () => XH.openWindow(`${model.referenceSite}${it.code}`),
                         minimal: false
                     })
                 ]

client-app/src/desktop/tabs/examples/ExamplesTab.ts

@@ -1,5 +1,5 @@
 import {div, filler, frame, hframe, iframe} from '@xh/hoist/cmp/layout';
-import {creates, hoistCmp} from '@xh/hoist/core';
+import {creates, hoistCmp, XH} from '@xh/hoist/core';
 import {button} from '@xh/hoist/desktop/cmp/button';
 import {panel} from '@xh/hoist/desktop/cmp/panel';
 import {toolbar} from '@xh/hoist/desktop/cmp/toolbar';
@@ -86,12 +86,15 @@ const appTile = hoistCmp.factory<ExamplesTabModel>(({app, model}) => {
                     text: 'Source',
                     icon: Icon.code(),
                     onClick: () =>
-                        window.open(toolboxUrl(`$TB/client-app/src/examples/${app.srcPath}`))
+                        XH.openWindow(
+                            toolboxUrl(`$TB/client-app/src/examples/${app.srcPath}`),
+                            'toolboxSource'
+                        )
                 }),
                 button({
                     text: 'Full Tab',
                     icon: Icon.openExternal(),
-                    onClick: () => window.open(`/${app.path}/`)
+                    onClick: () => XH.openWindow(`/${app.path}/`)
                 })
             ]
         }),
@@ -109,7 +112,7 @@ const sideBar = hoistCmp.factory<ExamplesTabModel>(({model}) => {
                     icon: app.icon,
                     active: isActive,
                     onClick: () =>
-                        isActive ? window.open(app.path) : (model.activeApp = app.title)
+                        isActive ? XH.openWindow(app.path) : (model.activeApp = app.title)
                 });
             }),
             filler(),

client-app/src/desktop/tabs/home/widgets/activity/ActivityWidgetModel.ts

@@ -28,7 +28,7 @@ export class ActivityWidgetModel extends HoistModel {
             tooltip: 'Open on Github',
             icon: Icon.icon({iconName: 'github', prefix: 'fab'}),
             displayFn: ({record}) => ({disabled: !record?.data?.url}),
-            actionFn: ({record}) => window.open(record.data.url)
+            actionFn: ({record}) => XH.openWindow(record.data.url, 'gitlink')
         };
 
         this.gridModel = new GridModel({
@@ -181,7 +181,7 @@ export class ActivityWidgetModel extends HoistModel {
 
     private onRowDoubleClicked = params => {
         const rec = params.data;
-        if (rec?.isRecord) window.open(rec.data.url);
+        if (rec?.isRecord) XH.openWindow(rec.data.url, 'gitlink');
     };
 
     private setGroupBy(groupBy) {

client-app/src/desktop/tabs/home/widgets/roadmap/RoadmapViewItem.ts

@@ -116,7 +116,7 @@ function getGitIcon(gitLinks) {
         gitIcon = Icon.icon({iconName: 'github', prefix: 'fab', size: '2x'});
 
     if (gitLinksList.length === 1) {
-        return button({icon: gitIcon, onClick: () => window.open(gitLinksList[0])});
+        return button({icon: gitIcon, onClick: () => XH.openWindow(gitLinksList[0], 'gitlink')});
     } else {
         return popover({
             minimal: true,
@@ -133,7 +133,7 @@ function getGitMenuItems(gitLinks) {
         return menuItem({
             text: link,
             icon: Icon.icon({iconName: 'github', prefix: 'fab'}),
-            onClick: () => window.open(link)
+            onClick: () => XH.openWindow(link, 'gitlink')
         });
     });
 }

client-app/src/desktop/tabs/mobile/MobileTab.tsx

@@ -61,7 +61,7 @@ export const mobileTab = hoistCmp.factory(() =>
                     text: 'Open Toolbox Mobile in this browser',
                     icon: Icon.mobile(),
                     minimal: false,
-                    onClick: () => window.open('/mobile')
+                    onClick: () => XH.openWindow('/mobile')
                 }),
                 filler()
             ],

client-app/src/examples/news/NewsPanelModel.ts

@@ -81,6 +81,6 @@ export class NewsPanelModel extends HoistModel {
 
     private onRowDoubleClicked({data: record}) {
         const url = record.get('url');
-        if (url) window.open(url, '_blank');
+        if (url) XH.openWindow(url, 'tb-news');
     }
 }