feat: add optional mysqlbinlog_path field on PITR create page

Add a non-required mysqlbinlog path input field to the PITR wizard.
If provided, the path is used directly; if left empty, the system
auto-discovers mysqlbinlog from PATH, MySQL basedir, or common
installation paths.

Author: Developer

internal/server/pitr/handler.go

@@ -55,11 +55,12 @@ func NewHandler(
 // ---------- request / response types ----------
 
 type startRequest struct {
-	AgentID      string `json:"agent_id"`
-	TargetTable  string `json:"target_table"`
-	RecoveryTime string `json:"recovery_time"`
-	Mode         string `json:"mode"` // "preview" or "execute"
-	MySQLDSN     string `json:"mysql_dsn"`
+	AgentID         string `json:"agent_id"`
+	TargetTable     string `json:"target_table"`
+	RecoveryTime    string `json:"recovery_time"`
+	Mode            string `json:"mode"` // "preview" or "execute"
+	MySQLDSN        string `json:"mysql_dsn"`
+	MySQLBinlogPath string `json:"mysqlbinlog_path,omitempty"`
 }
 
 type startResponse struct {
@@ -252,13 +253,14 @@ func (h *Handler) Start(w http.ResponseWriter, r *http.Request) {
 	}
 
 	op := &Operation{
-		OrgID:        agt.OrgID,
-		AgentID:      req.AgentID,
-		TargetTable:  req.TargetTable,
-		RecoveryTime: recoveryTime,
-		Mode:         req.Mode,
-		DSN:          req.MySQLDSN,
-		State:        StatePreflight,
+		OrgID:           agt.OrgID,
+		AgentID:         req.AgentID,
+		TargetTable:     req.TargetTable,
+		RecoveryTime:    recoveryTime,
+		Mode:            req.Mode,
+		DSN:             req.MySQLDSN,
+		MySQLBinlogPath: req.MySQLBinlogPath,
+		State:           StatePreflight,
 	}
 
 	if err := h.opStore.Create(op); err != nil {
@@ -497,9 +499,19 @@ func (h *Handler) Progress(w http.ResponseWriter, r *http.Request) {
 	})
 }
 
-// findMySQLBinlog locates the mysqlbinlog binary by checking PATH first, then
-// querying MySQL's basedir, and finally checking common installation paths.
-func findMySQLBinlog(ctx context.Context, conn *connector.MySQLConnector) (string, error) {
+// findMySQLBinlog locates the mysqlbinlog binary. If mysqlbinlogPath is
+// non-empty it is validated and returned directly. Otherwise the function
+// checks PATH, MySQL basedir, and common installation paths.
+func findMySQLBinlog(mysqlbinlogPath string, ctx context.Context, conn *connector.MySQLConnector) (string, error) {
+	// 0. Explicit path from user config — use it directly.
+	if mysqlbinlogPath != "" {
+		if fi, err := os.Stat(mysqlbinlogPath); err == nil && fi.Mode().IsRegular() {
+			abs, _ := filepath.Abs(mysqlbinlogPath)
+			return abs, nil
+		}
+		return "", fmt.Errorf("specified mysqlbinlog path %q does not exist", mysqlbinlogPath)
+	}
+
 	// 1. Try PATH first.
 	if path, err := exec.LookPath("mysqlbinlog"); err == nil {
 		return path, nil
@@ -533,7 +545,7 @@ func findMySQLBinlog(ctx context.Context, conn *connector.MySQLConnector) (strin
 		}
 	}
 
-	return "", fmt.Errorf("mysqlbinlog not found in $PATH, MySQL basedir, or common installation paths; install mysql-client or add mysqlbinlog to your PATH")
+	return "", fmt.Errorf("mysqlbinlog not found; install mysql-client or specify the path in the mysqlbinlog_path field")
 }
 
 // parseBinlogRemote uses mysqlbinlog --read-from-remote-server to parse binlog
@@ -797,7 +809,7 @@ func (h *Handler) runOperation(op *Operation, operator string) {
 	if len(paths) > 0 {
 		if _, statErr := os.Stat(paths[0]); os.IsNotExist(statErr) {
 			log.Printf("pitr: binlog files not accessible locally, trying mysqlbinlog remote for op %s", op.ID)
-			mysqlbinlogPath, findErr := findMySQLBinlog(ctx, conn)
+			mysqlbinlogPath, findErr := findMySQLBinlog(op.MySQLBinlogPath, ctx, conn)
 			if findErr != nil {
 				h.failOperation(op, "parse binlogs (remote): %v", findErr)
 				return

internal/server/pitr/store.go

@@ -11,21 +11,22 @@ import (
 // Operation represents a point-in-time recovery operation and its current
 // state within the workflow state machine.
 type Operation struct {
-	ID           string          `json:"id"`
-	OrgID        string          `json:"orgId"`
-	AgentID      string          `json:"agentId"`
-	TargetTable  string          `json:"targetTable"`
-	RecoveryTime time.Time       `json:"recoveryTime"`
-	Mode         string          `json:"mode"` // "preview" or "execute"
-	State        OperationState  `json:"state"`
-		DSN          string          `json:"-"`     // MySQL DSN, never exposed to frontend
-	PreflightRes *PreflightResult `json:"preflightResult,omitempty"`
-	ParseRes     *ParseSummary   `json:"parseResult,omitempty"`
-	ExecRes      *ExecSummary    `json:"execResult,omitempty"`
-	Progress     *ProgressInfo   `json:"progress,omitempty"`
-	Error        string          `json:"error,omitempty"`
-	CreatedAt    time.Time       `json:"createdAt"`
-	UpdatedAt    time.Time       `json:"updatedAt"`
+	ID              string          `json:"id"`
+	OrgID           string          `json:"orgId"`
+	AgentID         string          `json:"agentId"`
+	TargetTable     string          `json:"targetTable"`
+	RecoveryTime    time.Time       `json:"recoveryTime"`
+	Mode            string          `json:"mode"` // "preview" or "execute"
+	State           OperationState  `json:"state"`
+	DSN             string          `json:"-"`     // MySQL DSN, never exposed to frontend
+	MySQLBinlogPath string          `json:"-"`     // Optional explicit mysqlbinlog path
+	PreflightRes    *PreflightResult `json:"preflightResult,omitempty"`
+	ParseRes        *ParseSummary   `json:"parseResult,omitempty"`
+	ExecRes         *ExecSummary    `json:"execResult,omitempty"`
+	Progress        *ProgressInfo   `json:"progress,omitempty"`
+	Error           string          `json:"error,omitempty"`
+	CreatedAt       time.Time       `json:"createdAt"`
+	UpdatedAt       time.Time       `json:"updatedAt"`
 }
 
 // PreflightResult contains the output of the preflight check phase.

web/src/api/pitr.ts

@@ -7,6 +7,7 @@ export async function startPITR(data: {
   recovery_time: string;
   mode: 'preview' | 'execute';
   mysql_dsn: string;
+  mysqlbinlog_path?: string;
 }): Promise<{ operationId: string; status: string }> {
   const response = await apiClient.post<{ operationId: string; status: string }>('/pitr/start', data);
   return response.data;

web/src/locales/en.json

@@ -167,6 +167,9 @@
     "mysqlDsn": "MySQL DSN",
     "mysqlDsnHelp": "Format: user:password@tcp(host:port)/database",
     "mysqlDsnPlaceholder": "user:password@tcp(127.0.0.1:3306)/database",
+    "mysqlbinlogPath": "mysqlbinlog path (optional)",
+    "mysqlbinlogPathHelp": "Leave empty to auto-discover from system PATH",
+    "mysqlbinlogPathPlaceholder": "C:\Program Files\MySQL\MySQL Server 8.0\bin\mysqlbinlog.exe",
     "targetTablePlaceholder": "e.g. mydb.orders",
     "calculating": "Calculating...",
     "updatedAt": "Updated At",

web/src/locales/zh.json

@@ -167,6 +167,9 @@
     "mysqlDsn": "MySQL 连接串",
     "mysqlDsnHelp": "格式：user:password@tcp(host:port)/database",
     "mysqlDsnPlaceholder": "user:password@tcp(127.0.0.1:3306)/database",
+    "mysqlbinlogPath": "mysqlbinlog 路径（可选）",
+    "mysqlbinlogPathHelp": "留空则自动查找系统的 mysqlbinlog",
+    "mysqlbinlogPathPlaceholder": "C:\\Program Files\\MySQL\\MySQL Server 8.0\\bin\\mysqlbinlog.exe",
     "targetTablePlaceholder": "例如 mydb.orders",
     "calculating": "计算中...",
     "updatedAt": "更新时间",

web/src/pages/pitr/PITRWizardPage.tsx

@@ -51,6 +51,7 @@ export default function PITRWizardPage() {
   const [targetTable, setTargetTable] = useState('');
   const [recoveryTime, setRecoveryTime] = useState('');
   const [mysqlDsn, setMysqlDsn] = useState('');
+  const [mysqlBinlogPath, setMysqlBinlogPath] = useState('');
   const [operationId, setOperationId] = useState<string | null>(null);
 
   // Fetch agents list
@@ -99,6 +100,7 @@ export default function PITRWizardPage() {
       recovery_time: dayjs(recoveryTime).toISOString(),
       mode: 'execute',
       mysql_dsn: mysqlDsn,
+      mysqlbinlog_path: mysqlBinlogPath || undefined,
     }),
     onSuccess: (data) => {
       setOperationId(data.operationId);
@@ -256,6 +258,13 @@ export default function PITRWizardPage() {
           onChange={(e) => setMysqlDsn(e.target.value)}
         />
       </Form.Item>
+      <Form.Item label={t('pitr.mysqlbinlogPath')} help={t('pitr.mysqlbinlogPathHelp')}>
+        <Input
+          placeholder={t('pitr.mysqlbinlogPathPlaceholder')}
+          value={mysqlBinlogPath}
+          onChange={(e) => setMysqlBinlogPath(e.target.value)}
+        />
+      </Form.Item>
     </Form>
   );