Merge pull request #45 from xima-media/redirect-edit

feat: extend UrlUtility for dynamic URL building with redirect option

Author: Konrad Michalik

Classes/Service/MenuGenerator.php

@@ -18,6 +18,7 @@
 use Xima\XimaTypo3FrontendEdit\Event\FrontendEditDropdownModifyEvent;
 use Xima\XimaTypo3FrontendEdit\Template\Component\Button;
 use Xima\XimaTypo3FrontendEdit\Utility\ContentUtility;
+use Xima\XimaTypo3FrontendEdit\Utility\UrlUtility;
 
 final class MenuGenerator
 {
@@ -130,7 +131,7 @@ public function getDropdown(int $pid, string $returnUrl, int $languageUid, array
                     'edit',
                     ButtonType::Link,
                     label: $contentElement['CType'] === 'list' ? 'LLL:EXT:xima_typo3_frontend_edit/Resources/Private/Language/locallang.xlf:edit_plugin' : 'LLL:EXT:xima_typo3_frontend_edit/Resources/Private/Language/locallang.xlf:edit_content_element',
-                    url: GeneralUtility::makeInstance(UriBuilder::class)->buildUriFromRoute(
+                    url: UrlUtility::buildUrl(
                         'record_edit',
                         [
                             'edit' => [
@@ -141,8 +142,7 @@ public function getDropdown(int $pid, string $returnUrl, int $languageUid, array
                             ],
                             'returnUrl' => $returnUrlAnchor,
                         ]
-                    )->__toString()
-                    . '&tx_ximatypo3frontendedit', // add custom parameter to identify the request and render the save and close button in the edit form
+                    ) . '&tx_ximatypo3frontendedit', // add custom parameter to identify the request and render the save and close button in the edit form
                     icon: $contentElement['CType'] === 'list' ? 'content-plugin' : 'content-textpic'
                 );
                 $this->processNewButton(

Classes/Utility/UrlUtility.php

@@ -4,8 +4,12 @@
 
 namespace Xima\XimaTypo3FrontendEdit\Utility;
 
+use TYPO3\CMS\Backend\Routing\RouteRedirect;
+use TYPO3\CMS\Backend\Routing\UriBuilder;
+use TYPO3\CMS\Core\Configuration\ExtensionConfiguration;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 use TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer;
+use Xima\XimaTypo3FrontendEdit\Configuration;
 
 class UrlUtility
 {
@@ -25,4 +29,19 @@ public static function getUrl(int $pageId, ?int $languageUid = 0, bool $forceAbs
 
         return $contentObjectRenderer->typoLink_URL($typolinkConfiguration);
     }
+
+    public static function buildUrl(string $route, array $parameters): string
+    {
+        $useRedirect = false;
+        $extensionConfiguration = GeneralUtility::makeInstance(ExtensionConfiguration::class);
+        if (isset($extensionConfiguration->get(Configuration::EXT_KEY)['useRedirect']) && $extensionConfiguration->get(Configuration::EXT_KEY)['useRedirect']) {
+            $useRedirect = true;
+        }
+
+        if ($useRedirect) {
+            return GeneralUtility::makeInstance(UriBuilder::class)->buildUriWithRedirect('main', [], RouteRedirect::create($route, $parameters))->__toString();
+        }
+
+        return GeneralUtility::makeInstance(UriBuilder::class)->buildUriFromRoute($route, $parameters)->__toString();
+    }
 }

Documentation/Configuration/ExtensionConfiguration.rst

@@ -42,3 +42,15 @@ The extension currently provides the following configuration options:
     :Default: 0
 
     This mode will disable the menu dropdown and use the edit icon button directly as edit link instead
+
+..  _extconf-useRedirect:
+
+..  confval:: Redirect
+    :type: boolean
+    :Default: 0
+
+    Use the redirect option to redirect the edit links, so the full TYPO3 backend is loaded instead of only the edit form
+
+    ..  warning::
+        This option is useful if you want to use the full TYPO3 backend, e.g. language switch or modal popups for for inline group type.
+        But keep in mind, that with this option the return to the frontend using the "close" button will not work anymore.

Documentation/FAQ/Index.rst

@@ -44,3 +44,10 @@ After closing the edit form will I redirected to the wrong frontend location, e.
 =======================================
 
 This could be caused by a strict referer header in your request. If the return url could not be determined correctly, you can force the url generation by pid and language in the extension setting: :code:`forceReturnUrlGeneration`.
+
+.. rst-class:: panel panel-default
+
+I can't change the language within a content element.
+=======================================
+
+This is a TYPO3 backend limitation. The reduced edit form frame does not support the language switch. Use the :ref:`redirect <extconf-useRedirect>` configuration in the extension settings to open the edit form within the full TYPO3 backend context, which supports the language switch.

ext_conf_template.txt

@@ -6,3 +6,5 @@ forceReturnUrlGeneration = 0
 linkTargetBlank = 0
 # cat=basic//103; type=boolean; label=Simple mode: This mode will disable the menu dropdown and use the edit icon button directly as edit link instead
 simpleMode = 0
+# cat=basic//104; type=boolean; label=Redirect: Use the redirect option to redirect the edit links, so the full TYPO3 backend is loaded instead of only the edit form
+useRedirect = 0