Fix metaflac --import-tags-from-file, allow missing newline and \r

Remove one extra feof() call since it would prevent the last line
from being added if it was missing a newline at the end.

Check for both \r and \n, since otherwise the tags will be added with
an extra \r included in the tag value, which is unexpected.

Fixes #856

Author: madah81pnz1

src/metaflac/operations_shorthand_vorbiscomment.c

@@ -359,33 +359,39 @@ FLAC__bool import_vc_from(const char *filename, FLAC__StreamMetadata *block, con
 
 	ret = true;
 	while(ret && !feof(f) && fgets(line, sizeof(line), f) != NULL) {
-		if(!feof(f)) {
-			char *p = strchr(line, '\n');
-			if(0 == p) {
+		char *p = strpbrk(line, "\r\n");
+		if(0 == p) {
+			const size_t len = strlen(line);
+			if(len < (sizeof(line) - 1)) {
+				/* Likely missing newline in the last line, allow this */
+				p = &line[len];
+			}
+			else {
 				flac_fprintf(stderr, "%s: ERROR: line too long, aborting\n", vc_filename->value);
 				ret = false;
 			}
+		}
+
+		if(ret) {
+			const char *violation;
+			Argument_VcField field;
+			*p = '\0';
+			memset(&field, 0, sizeof(Argument_VcField));
+			field.field_value_from_file = false;
+			if(!parse_vorbis_comment_field(line, &field.field, &field.field_name, &field.field_value, &field.field_value_length, &violation)) {
+				FLAC__ASSERT(0 != violation);
+				flac_fprintf(stderr, "%s: ERROR: malformed vorbis comment field \"%s\",\n       %s\n", vc_filename->value, line, violation);
+				ret = false;
+			}
 			else {
-				const char *violation;
-				Argument_VcField field;
-				*p = '\0';
-				memset(&field, 0, sizeof(Argument_VcField));
-				field.field_value_from_file = false;
-				if(!parse_vorbis_comment_field(line, &field.field, &field.field_name, &field.field_value, &field.field_value_length, &violation)) {
-					FLAC__ASSERT(0 != violation);
-					flac_fprintf(stderr, "%s: ERROR: malformed vorbis comment field \"%s\",\n       %s\n", vc_filename->value, line, violation);
-					ret = false;
-				}
-				else {
-					ret = set_vc_field(filename, block, &field, needs_write, raw);
-				}
-				if(0 != field.field)
-					free(field.field);
-				if(0 != field.field_name)
-					free(field.field_name);
-				if(0 != field.field_value)
-					free(field.field_value);
+				ret = set_vc_field(filename, block, &field, needs_write, raw);
 			}
+			if(0 != field.field)
+				free(field.field);
+			if(0 != field.field_name)
+				free(field.field_name);
+			if(0 != field.field_value)
+				free(field.field_value);
 		}
 	};
 

test/test_metaflac.sh

@@ -354,6 +354,18 @@ echo "TITLE=Tittle" | run_metaflac --import-tags-from=- $flacfile
 check_flac
 metaflac_test case39 "--import-tags-from=-" "--list"
 
+# Run same test again, but with \r\n newline:
+run_metaflac --remove-all-tags --set-tag="f=0123456789abcdefghij" $flacfile
+printf 'TITLE=Tittle\r\n' | run_metaflac --import-tags-from=- $flacfile
+check_flac
+metaflac_test case39 "--import-tags-from=-" "--list"
+
+# Run same test again, but without newline at the end:
+run_metaflac --remove-all-tags --set-tag="f=0123456789abcdefghij" $flacfile
+echo -n "TITLE=Tittle" | run_metaflac --import-tags-from=- $flacfile
+check_flac
+metaflac_test case39 "--import-tags-from=-" "--list"
+
 cat > vc.txt << EOF
 artist=Fartist
 artist=artits
@@ -362,6 +374,20 @@ run_metaflac --import-tags-from=vc.txt $flacfile
 check_flac
 metaflac_test case40 "--import-tags-from=[FILE]" "--list"
 
+# Run same test again, but with \r\n newlines:
+printf 'artist=Fartist\r\nartist=artits\r\n' >vc.txt
+run_metaflac --remove-all-tags --set-tag="f=0123456789abcdefghij" --set-tag="TITLE=Tittle" $flacfile
+run_metaflac --import-tags-from=vc.txt $flacfile
+check_flac
+metaflac_test case40 "--import-tags-from=[FILE]" "--list"
+
+# Run same test again, but without newline at the end:
+printf 'artist=Fartist\nartist=artits' >vc.txt
+run_metaflac --remove-all-tags --set-tag="f=0123456789abcdefghij" --set-tag="TITLE=Tittle" $flacfile
+run_metaflac --import-tags-from=vc.txt $flacfile
+check_flac
+metaflac_test case40 "--import-tags-from=[FILE]" "--list"
+
 rm vc.txt
 
 run_metaflac --add-replay-gain $flacfile