metaflac: print error if no operations (#876)

madah81pnz1 · web-flow · commit d1189379bc64 · 2026-02-22T20:33:17.000+01:00
This solves the issue of giving no indication if the wrong command line was used. Fixes #861
diff --git a/src/metaflac/options.c b/src/metaflac/options.c
@@ -216,6 +216,12 @@ FLAC__bool parse_options(int argc, char *argv[], CommandLineOptions *options)
 		}
 	}
 
+	if(!options->show_long_help && !options->show_version &&
+	   (options->args.checks.num_major_ops == 0) && (options->args.checks.num_shorthand_ops == 0)) {
+		flac_fprintf(stderr, "ERROR: no operations specified\n");
+		had_error = true;
+	}
+
 	/* check for only one FLAC file used with certain options */
 	if(!had_error && options->num_files > 1) {
 		if(0 != options->output_name) {

Original file line number	Diff line number	Diff line change
`@@ -216,6 +216,12 @@ FLAC__bool parse_options(int argc, char argv[], CommandLineOptions options)`
`216`	`216`	`}`
`217`	`217`	`}`
`218`	`218`
	`219`	`+ if(!options->show_long_help && !options->show_version &&`
	`220`	`+ (options->args.checks.num_major_ops == 0) && (options->args.checks.num_shorthand_ops == 0)) {`
	`221`	`+ flac_fprintf(stderr, "ERROR: no operations specified\n");`
	`222`	`+ had_error = true;`
	`223`	`+ }`
	`224`	`+`
`219`	`225`	`/* check for only one FLAC file used with certain options */`
`220`	`226`	`if(!had_error && options->num_files > 1) {`
`221`	`227`	`if(0 != options->output_name) {`