Skip to content

Commit 1f31e7f

Browse files
committed
Fix Windows MSVC build errors
1. Fix lambda capture in smart_nframes() (vision_utils.cpp): MSVC requires explicit capture of constexpr variable FRAME_FACTOR in lambdas. Changed [] to [FRAME_FACTOR] for floor2/ceil2 lambdas. 2. Fix yaml-cpp linker errors for modeling_qwen3_vl target: Add missing to target_link_libraries. The yaml-cpp symbols were not propagated through openvino_genai_obj LINK_LIBRARIES property, causing LNK2019 unresolved externals.
1 parent 2388958 commit 1f31e7f

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

samples/cpp/module_genai/utils/vision_utils.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,8 @@ std::pair<int, int> smart_resize_video(int height, int width,
134134
int smart_nframes(int total_frames, double video_fps,
135135
float target_fps = 2.0f, int min_frames = 4, int max_frames = 768) {
136136
constexpr int FRAME_FACTOR = 2;
137-
auto floor2 = [](double v) { return (int)(std::floor(v / FRAME_FACTOR) * FRAME_FACTOR); };
138-
auto ceil2 = [](double v) { return (int)(std::ceil(v / FRAME_FACTOR) * FRAME_FACTOR); };
137+
auto floor2 = [FRAME_FACTOR](double v) { return (int)(std::floor(v / FRAME_FACTOR) * FRAME_FACTOR); };
138+
auto ceil2 = [FRAME_FACTOR](double v) { return (int)(std::ceil(v / FRAME_FACTOR) * FRAME_FACTOR); };
139139

140140
int min_f = std::max(FRAME_FACTOR, ceil2(min_frames));
141141
int max_f = std::max(FRAME_FACTOR, floor2(std::min(max_frames, total_frames)));

src/cpp/src/modeling/samples/CMakeLists.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@ target_include_directories(modeling_qwen3_vl PRIVATE
1919
$<TARGET_PROPERTY:openvino::genai,INTERFACE_INCLUDE_DIRECTORIES>)
2020

2121
target_link_libraries(modeling_qwen3_vl PRIVATE
22-
$<TARGET_PROPERTY:openvino_genai_obj,LINK_LIBRARIES>)
22+
$<TARGET_PROPERTY:openvino_genai_obj,LINK_LIBRARIES>
23+
${YAML_CPP_TARGET})
2324

2425
target_compile_definitions(modeling_qwen3_vl PRIVATE
2526
openvino_genai_EXPORTS)

0 commit comments

Comments
 (0)