-
Notifications
You must be signed in to change notification settings - Fork 88
Open
Description
At the moment, when the lib calls s3manager.Uploader.Upload, it constructs a default parameter input *UploadInput:
Lines 305 to 309 in 88e6b03
| uploadParams := &s3manager.UploadInput{ | |
| Bucket: aws.String(s.BucketName), | |
| Key: aws.String(s.Key), | |
| Body: s.pipeReader, | |
| } |
This will suffice in most cases. However, this doesn't allow setting other upload options, e.g. SSEKMSKeyId
To allow more flexibility, how about using UploadInput here to replace both bucket and key?
Lines 69 to 73 in 88e6b03
| // NewS3FileWriter creates an S3 FileWriter, to be used with NewParquetWriter | |
| func NewS3FileWriter( | |
| ctx context.Context, | |
| bucket string, | |
| key string, |
iivansmaliakou and Nitjsefni7
Metadata
Metadata
Assignees
Labels
No labels