Commit 19af6fe
authored
Fix iPad share sheet covering QR code (#539)
* Fix iPad share sheet covering QR code (#539)
The share sheet popover on iPad was appearing centered over the QR code, covering it entirely.
Now the popover anchors to the bottom of the source view with an upward arrow, so the QR code remains visible. Fixes both ConversationShareView and AutoShareSheetView.
Stacked on #538.
<!-- Macroscope's pull request summary starts here -->
<!-- Macroscope will only edit the content between these invisible markers, and the markers themselves will not be visible in the GitHub rendered markdown. -->
<!-- If you delete either of the start / end markers from your PR's description, Macroscope will append its summary at the bottom of the description. -->
> [!NOTE]
> ### Anchor iPad share sheet popover to bottom to avoid covering QR code
> - Updates `UIActivityViewController` popover configuration in [ConversationShareView.swift](https://github.com/xmtplabs/convos-ios/pull/539/files#diff-0b61b1a39f237dac83028d3a0b4a1ba744cb88f15934fd101e4b1f3a68cbbec9) and [AutoShareSheetView.swift](https://github.com/xmtplabs/convos-ios/pull/539/files#diff-621c78e434aee4ede856c47b009aefd7589beefb5c9aaf92b90c0ec022b5bf6a) to anchor to the bottom of the view with an upward arrow instead of centering without arrows
> - Adjusts message attachment placeholder alignment in [MessagesGroupItemView.swift](https://github.com/xmtplabs/convos-ios/pull/539/files#diff-34b33cae925fe553d357af97d04319b8de2de329c1903afe72c915e36aa98774) to align trailing for outgoing messages and leading for incoming messages in regular width, with side padding
>
> <!-- Macroscope's review summary starts here -->
>
> <sup><a href="https://app.macroscope.com">Macroscope</a> summarized 37fceeb.</sup>
> <!-- Macroscope's review summary ends here -->
>
<!-- macroscope-ui-refresh -->
<!-- Macroscope's pull request summary ends here -->
* Add bottom padding to quickname sheet on iPad (#540)
* Fix iPad photo alignment: left-align incoming, right-align outgoing
Photos on iPad were center-aligned. Now incoming photos align to the
leading edge and outgoing photos align to the trailing edge, with
step4x (16pt) padding on the respective side. Applies to loaded
photos, loading placeholders, and error placeholders.
* Fix iPad share sheet covering QR code
Position the share sheet popover at the bottom of the source view
with an upward arrow direction, so it appears below the QR code
instead of covering it. Fixes both ConversationShareView and
AutoShareSheetView.
* Reduce QR code size on iPhone to avoid share sheet overlap
Increase shareSheetFraction from 0.45 to 0.55 so the QR code sizes
itself smaller, leaving room for the share sheet on iPhone.
* Add bottom padding to quickname sheet on iPad
Match the bottom padding used by FeatureInfoSheet: step10x on iPad
(regular width), step6x on iPhone.
---------
Co-authored-by: yewreeka <7864+yewreeka@users.noreply.github.com>1 parent fc1eb8e commit 19af6fe
3 files changed
Lines changed: 7 additions & 5 deletions
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
| |||
58 | 59 | | |
59 | 60 | | |
60 | 61 | | |
| 62 | + | |
61 | 63 | | |
62 | 64 | | |
63 | 65 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| |||
187 | 187 | | |
188 | 188 | | |
189 | 189 | | |
190 | | - | |
| 190 | + | |
191 | 191 | | |
192 | 192 | | |
193 | 193 | | |
194 | | - | |
| 194 | + | |
195 | 195 | | |
196 | 196 | | |
197 | 197 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
75 | | - | |
| 75 | + | |
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
79 | | - | |
| 79 | + | |
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
| |||
0 commit comments