Commit b42e206
authored
Fix test interference from shared notification IDs (#524)
Test fixtures in IncomingMessageWriterExplodeTests and
ExpiredConversationsWorkerTests both used the hardcoded conversation ID
"test-conversation-id". When Swift Testing runs suites in parallel,
a .conversationExpired notification posted by one suite's test could be
captured by another suite's NotificationCapture, causing
testPastDatePostsExpiredNotification to see count == 2 instead of 1.
Fix: use unique UUIDs for conversation IDs in test fixtures and filter
captured notifications by conversationId.1 parent 4677e43 commit b42e206
2 files changed
Lines changed: 6 additions & 6 deletions
File tree
- ConvosCore/Tests/ConvosCoreTests
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
170 | 170 | | |
171 | 171 | | |
172 | 172 | | |
173 | | - | |
| 173 | + | |
174 | 174 | | |
175 | 175 | | |
176 | 176 | | |
| |||
Lines changed: 5 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
230 | 230 | | |
231 | 231 | | |
232 | 232 | | |
233 | | - | |
234 | | - | |
235 | | - | |
236 | | - | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
237 | 237 | | |
238 | 238 | | |
239 | 239 | | |
| |||
266 | 266 | | |
267 | 267 | | |
268 | 268 | | |
269 | | - | |
| 269 | + | |
270 | 270 | | |
271 | 271 | | |
272 | 272 | | |
| |||
0 commit comments