Move plugins from plugins.cjs to `eslint-config-xo`

[fregante]

xo/config/plugins.cjs

Lines 13 to 21 in 1877df6

	plugins: [
	'no-use-extend-native',
	'ava',
	'unicorn',
	'promise',
	'import',
	'n', // eslint-plugin-node's successor
	'eslint-comments',
	],

Flat configs can now have plugin dependencies, so they should be moved to eslint-config-xo. This would extend the existing json and stylistic plugins: https://github.com/xojs/eslint-config-xo/blob/e1fe11ca81699991253ad4a9c6efa54bdb76b011/package.json#L62-L63

Related

• Move to flat config #702
• Migrate to flat config eslint-config-xo#86

[fregante]

@spence-s after #774 it would be great to move this config (and its plugins) to the eslint-config-xo package now that the flat config supports it.

This would let eslint-config-xo users get the xo config for plugins as well, and for xo maintainers to update the config in a single repository

[spence-s]

I don't really have a strong opinion on where the base config ends up, so I am happy either way if it stays in xo or if its moved eslint-config-xo...

However, I do have 1 reservation about moving it, is that there are some users who use eslint-config-xo with their own setups where they define their own eslint plugins and just use eslint-config-xo to configure the core ESLint rules only.

Moving our plugins/config there would mean users who currently use eslint-config-xo in that way would likely move to another eslint config or have to deal with a lot of new and potentially conflicting stuff in the eslint-config-xo

If we are ok with alienating those users, or forcing them to use our plugin setup, then this is ok, but it is just something to consider.

[fregante]

alienating those users

As a user of XO, I use eslint-config-xo when I want to "eject" or if I can't convince the team to switch to XO. To me having an "base-eslint-only" "XO config" doesn't make sense. XO is all the plugins too.

This is also what other configs do:

• https://github.com/antfu/eslint-config
• https://github.com/neostandard/neostandard

[spence-s]

Note that with the next version you can "eject" by:

If you want to use all the plugins:

eslint.config.js

import xo from 'xo';

export default await xo.xoToEslintConfig(); // this returns the base eslint config with all the plugins

If you want to use just the eslint rules config and set up other plugins yourself.

eslint.config.js

import config from 'eslint-config-xo';

export default [
...config
];

I am just pointing out here, that if you move all the plugins to eslint-config-xo you lose option 2 to configure your own plugins.

As I said, this wouldn't affect my usage either way, and I am not against the move at all. I do think its something to consider though as there is a tradeoff here with the move.

[fregante]

While it doesn't prevent installing the dependencies, the package can export as many configs as needed.

import config from 'eslint-config-xo';

import config from 'eslint-config-xo/only-native-rules';

[sindresorhus]

I think we will rather to options than sub-exports:

import config from 'eslint-config-xo';

export default [
  ...config({space: true})
];

[fregante]

True. Other configs also let you disable plugins one by one:

import config from 'eslint-config-xo';

export default [
  ...config({space: true, ava: false})
];

For XO, this would also mean optionally exposing React via react: true.

[fregante]

I think this is the only item left from the flat config / v9 migration. eslint-config-xo users still don't receive XO config for the plugins.