Skip to content

Commit 6437a11

Browse files
committed
Fix coverage to use line coverage instead of method coverage when creating badge for coverage results
1 parent 7a09f53 commit 6437a11

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/dotnet-releaser/ReleaserApp.BuildAndTests.cs

+3-3
Original file line numberDiff line numberDiff line change
@@ -81,12 +81,12 @@ private async Task<bool> BuildAndTest(IDevHosting? devHosting, BuildInformation
8181
{
8282
if (_config.Coverage.Enable)
8383
{
84-
var coverageResult = LoadAndDisplayCoverageResults();
84+
var lineCoverageResult = LoadAndDisplayCoverageResults();
8585

8686
// Publish badge if requested
8787
if (devHosting is not null)
8888
{
89-
await PublishCoverageToGist(devHosting, buildInfo, coverageResult);
89+
await PublishCoverageToGist(devHosting, buildInfo, lineCoverageResult);
9090
}
9191
}
9292

@@ -160,7 +160,7 @@ private HitCoverage LoadAndDisplayCoverageResults()
160160

161161
_logger.InfoMarkup("Coverage Results:", table);
162162

163-
return totalMethodRate;
163+
return totalLineRate;
164164
}
165165

166166
private async Task<bool> Build(string projectFile, bool isTestProject)

src/dotnet-releaser/ReleaserApp.Coverage.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ namespace DotNetReleaser;
1313

1414
public partial class ReleaserApp
1515
{
16-
private async Task PublishCoverageToGist(IDevHosting devHosting, BuildInformation buildInfo, HitCoverage coverage)
16+
private async Task PublishCoverageToGist(IDevHosting devHosting, BuildInformation buildInfo, HitCoverage lineCoverage)
1717
{
1818
if (!_config.Coverage.BadgeUploadToGist || !buildInfo.IsPush) return;
1919

@@ -24,7 +24,7 @@ private async Task PublishCoverageToGist(IDevHosting devHosting, BuildInformatio
2424
return;
2525
}
2626

27-
var rate = (int)Math.Round((double)coverage.Rate * 100);
27+
var rate = (int)Math.Round((double)lineCoverage.Rate * 100);
2828

2929
// TODO: We could make many of these things configurable (colors, size of the badge, etc.)
3030
var color = rate switch

0 commit comments

Comments
 (0)