Refrain from using LONG_MIN / LONG_MAX

See xp-framework/rfc#288

Author: thekid

src/main/php/lang.base.php

@@ -629,8 +629,6 @@ function __construct($str) {
 // {{{ main
 date_default_timezone_set(ini_get('date.timezone')) || xp::error('[xp::core] date.timezone not configured properly.');
 
-define('LONG_MAX', PHP_INT_MAX);
-define('LONG_MIN', -PHP_INT_MAX - 1);
 define('MODIFIER_STATIC',       1);
 define('MODIFIER_ABSTRACT',     2);
 define('MODIFIER_FINAL',        4);

src/test/php/net/xp_framework/unittest/tests/AssertionsTest.class.php

@@ -69,12 +69,12 @@ public function equals($other) {
     $this->assertEquals(2, $instance->equalsInvoked);
   }
 
-  #[@test, @values([0, 1, -1, LONG_MAX, LONG_MIN])]
+  #[@test, @values([0, 1, -1, PHP_INT_MAX])]
   public function integersAreEqual($int) {
     $this->assertEquals($int, $int);
   }    
 
-  #[@test, @values(['', 'Hello', 'äöüß'])]
+  #[@test, @values(['', 'Hello', 'äöüß'])]
   public function stringsAreEqual($str) {
     $this->assertEquals($str, $str);
   }    
@@ -103,7 +103,7 @@ public function hashesOrderNotRelevant() {
     $this->assertEquals($hash, array_reverse($hash, true), \xp::stringOf($hash));
   }    
 
-  #[@test, @values([new String(''), new String('Hello'), new String('äöüß', 'iso-8859-1')])]
+  #[@test, @values([new String(''), new String('Hello'), new String('äöüß')])]
   public function stringObjectsAreEqual($str) {
     $this->assertEquals($str, $str);
   }

src/test/php/net/xp_framework/unittest/util/ObjectsTest.class.php

@@ -14,7 +14,7 @@ class ObjectsTest extends TestCase {
   public function primitives() {
     return [
       [false], [true],
-      [1], [0], [-1], [LONG_MAX], [LONG_MIN],
+      [1], [0], [-1], [PHP_INT_MAX], [-PHP_INT_MAX -1],
       [1.0], [0.5], [-6.1],
       [''], ['String'], ["\0"]
     ];