Skip to content

Commit 134585d

Browse files
authored
Numerical atmos test runs fixed to not go beyond atmosphere table limits. (#605)
* Numerical atmos test runs fixed to not go beyond atmosphere table limits. Also made an output name change to allow simultaneous running of the 2 tests.
1 parent 5ad59fe commit 134585d

4 files changed

Lines changed: 13 additions & 5 deletions

File tree

changelog.d/605.attribution.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Tuomo Salmi

changelog.d/605.fixed.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fixed the example runs with numerical atmosphere data to not extrapolate beyond the atmosphere table limits.

examples/examples_modeling_tutorial/TestRun_Num.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,10 @@ def from_response_files(cls, ARF, RMF, channel_edges, max_input,
114114
bounds = dict(super_colatitude = (None, None),
115115
super_radius = (None, None),
116116
phase_shift = (0.0, 0.1),
117-
super_temperature = (5.1, 6.8))
117+
super_temperature = (5.3, 6.8))
118+
#Note: The atmosphere table lower limit is 5.1, but we use 5.3 in this example,
119+
#because the secondary spot temperature is defined here to be always 0.2 below
120+
#the primary spot temperature (just for demonstrating how to derive parameters).
118121

119122
primary = xpsi.HotRegion(bounds=bounds,
120123
values={},

examples/examples_modeling_tutorial/TestRun_NumBeam.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -117,10 +117,13 @@ def from_response_files(cls, ARF, RMF, channel_edges, max_input,
117117
bounds = dict(super_colatitude = (None, None),
118118
super_radius = (None, None),
119119
phase_shift = (0.0, 0.1),
120-
super_temperature = (5.1, 6.8),
120+
super_temperature = (5.3, 6.8),
121121
super_abb = (-0.7, 0.7),
122-
super_bbb = (-0.7, 0.7))
123-
122+
super_bbb = (-0.7, 0.7))
123+
#Note: The atmosphere table lower limit is 5.1, but we use 5.3 in this example,
124+
#because the secondary spot temperature is defined here to be always 0.2 below
125+
#the primary spot temperature (just for demonstrating how to derive parameters).
126+
124127
from modules.CustomHotRegion_Beaming import CustomHotRegion
125128

126129
primary = CustomHotRegion(bounds=bounds,
@@ -539,7 +542,7 @@ def transform(self, p, **kwargs):
539542
'importance_nested_sampling': False,
540543
'multimodal': False,
541544
'n_clustering_params': None,
542-
'outputfiles_basename': './run/run_Num',
545+
'outputfiles_basename': './run/run_NumBeam',
543546
'n_iter_before_update': 50,
544547
'n_live_points': 50,
545548
'sampling_efficiency': 0.8,

0 commit comments

Comments
 (0)