Correcting mistakes in new InstrumentPileup (#628)

* correcting mistakes in new instrument for pileup

* changelog updated

* new version

* Updated version number

---------

Co-authored-by: lmauviard <73354617+lmauviard@users.noreply.github.com>

Author: ckazantsev

changelog.d/628.fixed.rst

@@ -0,0 +1 @@
+Corrected a bug in ``InstrumentPileup`` to call ``super()``, where the RMF and ARF arguments were missing and needed.

xpsi/Instrument.py

@@ -556,14 +556,16 @@ def __call__(self, signal, *args):
                   'Response matrix loaded')
     def from_ogip_fits(cls,
               Data_path,
+              ARF_path,
+              RMF_path,
               bounds=dict(),
               values=dict(),
               **kwargs):
 
         """ Load any instrument response matrix. """
 
         # Load the default instrument class
-        Instrument = super().from_ogip_fits(**kwargs)
+        Instrument = super().from_ogip_fits(RMF_path, ARF_path=ARF_path, **kwargs) 
 
         ## -------- INITIALIZATION OF THE PILEUP ---------------
 
@@ -608,9 +610,8 @@ def from_ogip_fits(cls,
             Data_header = hdul['SPECTRUM'].header 
 
         if kwargs.get( 'datafolder', None ) is not None:
-            ARF_path = _os.path.join( kwargs.get( 'datafolder'), kwargs.get( 'ARF_path' ) )
-        else:
-            ARF_path = kwargs.get( 'ARF_path' )
+            ARF_path = _os.path.join( kwargs.get( 'datafolder'), ARF_path )
+
         with fits.open( ARF_path ) as hdul:
             ARF_header = hdul['SPECRESP'].header