Skip to content

names of "module binaries" do not convey "feff8l"-ness #36

@newville

Description

@newville

Currently (unless I'm mistaken), make install installs

  • PREFIX/bin/: ff2x, genfmt, pathfinder, pot, rdinp, xsph

  • PREFIX/lib/: json_module.mod, libfeffpath.EXT, libfeffphases.EXT, libjsonfortran.a, libonepath.EXT, libpotph.EXT

  • PREFIX/include: feffpath.h, feffphases.h

where EXT='so' for linux, 'dylib' for Mac, 'dll' for Windows.

I see three problems here:

  1. there actually isn't a "feff8l" script or executable.
  2. there really isn't anything that clearly identifies these as belonging to "feff8l".
  3. it's not really clear to me why there are so many "feff8l libraries".

I propose condensing the shared libraries libfeffpath.EXT, libfeffphases.EXT, and libonepath.EXT
to a single libfeff8l.EXT, and changing the name for the installed binary files:

bin/ff2x -> bin/feff8l_ff2chi
bin/genfmt -> bin/feff8l_genfmt
bin/pathfinder -> bin/feff8l_pathfinder
bin/pot -> bin/feff8l_potentials
bin/rdinp -> bin/feff8l_readinp
bin/xsph -> bin/feff8l_phases

We can then also include a bash file (or bat file for Windows) that runs all of these.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions