fix for/for_class parameter that don't match between doc and code

The documentation describing the apply_base_class_role() method of the
Mouse::Util::MetaRole package, and other similar methods, explains that
it takes "for" parameter.

However, they actually take a parameter with the name "for_class", which
can be confusing to users and needs to be fixed.

So in the apply_base_class_role() method, we also use the
_fixup_old_style_args() function to convert the old parameter style to
the current one.

Signed-off-by: Jihyeon Gim <[email protected]>

Author: potatogim

Moose-t-failing/050_metaclasses/050_metarole_backcompat.t

@@ -223,8 +223,8 @@ use Mouse::Util::MetaRole;
 
 {
     Mouse::Util::MetaRole::apply_base_class_roles(
-        for_class => 'My::Class',
-        roles     => ['Role::Foo'],
+        for   => 'My::Class',
+        roles => ['Role::Foo'],
     );
 
     ok( My::Class->meta()->does_role('Role::Foo'),

lib/Mouse/Util/MetaRole.pm

@@ -104,11 +104,12 @@ sub _fixup_old_style_args {
     return;
 }
 
-
 sub apply_base_class_roles {
     my %options = @_;
 
-    my $for = $options{for_class};
+    _fixup_old_style_args(\%options);
+
+    my $for = $options{for};
 
     my $meta = Mouse::Util::class_of($for);