Skip to content

Commit 11c3f81

Browse files
author
maxonfjvipon
committed
bug: fix CI — drop Kover, cross-platform npm, de-flake matrix
Kover 0.9.1 reads the compileKotlinTask property removed in Kotlin 2.x, which broke build/coverage config and the verify compile under the IntelliJ Platform plugin's compilation model. Remove Kover (coverage of this thin adapter is low-value; JaCoCo can return later if wanted). Also: launch npm via npm.cmd on Windows so the server-bundling task works there, switch tasks.registering to tasks.register (Gradle 9.6 deprecation), set fail-fast: false on the matrix, and raise the Gradle heap. Clean no-cache build passes locally.
1 parent ca56419 commit 11c3f81

6 files changed

Lines changed: 7 additions & 41 deletions

File tree

.github/workflows/build.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ jobs:
1616
build:
1717
runs-on: ${{ matrix.os }}
1818
strategy:
19+
fail-fast: false
1920
matrix:
2021
os:
2122
- ubuntu-24.04

.github/workflows/coverage.yml

Lines changed: 0 additions & 32 deletions
This file was deleted.

CONTRIBUTING.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ Requires **JDK 21** and **Node.js**. The Gradle wrapper pins everything else.
1010
./gradlew build # compile, test, and assemble the plugin
1111
./gradlew runIde # try it in a sandbox IDE
1212
./gradlew detekt # Kotlin static analysis
13-
./gradlew koverXmlReport # coverage report
1413
./gradlew verifyPlugin # the JetBrains Plugin Verifier
1514
```
1615

@@ -21,5 +20,5 @@ Requires **JDK 21** and **Node.js**. The Gradle wrapper pins everything else.
2120
[xslint-lsp](https://github.com/xslint/xslint-lsp); logic belongs upstream,
2221
not here.
2322
- Every source file carries an SPDX header — run `reuse lint` to check.
24-
- Open a pull request; CI (build, coverage, detekt, plugin verifier, REUSE,
25-
and the meta-linters) must be green before it merges.
23+
- Open a pull request; CI (build, detekt, plugin verifier, REUSE, and the
24+
meta-linters) must be green before it merges.

README.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
# xslint-jetbrains
22

33
[![build](https://github.com/xslint/xslint-jetbrains/actions/workflows/build.yml/badge.svg)](https://github.com/xslint/xslint-jetbrains/actions/workflows/build.yml)
4-
[![codecov](https://codecov.io/gh/xslint/xslint-jetbrains/branch/master/graph/badge.svg)](https://codecov.io/gh/xslint/xslint-jetbrains)
54
[![Hits-of-Code](https://hitsofcode.com/github/xslint/xslint-jetbrains)](https://hitsofcode.com/view/github/xslint/xslint-jetbrains)
65
[![License](https://img.shields.io/badge/license-MIT-green.svg)](https://github.com/xslint/xslint-jetbrains/blob/master/LICENSE.txt)
76

@@ -45,7 +44,6 @@ reuse the same engine.
4544
./gradlew buildPlugin # build the distributable .zip (build/distributions)
4645
./gradlew runIde # launch a sandbox IDE with the plugin loaded
4746
./gradlew test # unit tests
48-
./gradlew koverXmlReport # coverage report (build/reports/kover)
4947
./gradlew detekt # Kotlin static analysis
5048
./gradlew verifyPlugin # the JetBrains Plugin Verifier
5149
```

build.gradle.kts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import org.jetbrains.kotlin.gradle.dsl.KotlinVersion
77
plugins {
88
id("org.jetbrains.kotlin.jvm") version "2.1.20"
99
id("org.jetbrains.intellij.platform") version "2.18.1"
10-
id("org.jetbrains.kotlinx.kover") version "0.9.1"
1110
id("io.gitlab.arturbosch.detekt") version "1.23.7"
1211
}
1312

@@ -73,14 +72,15 @@ detekt {
7372
// Fetch the xslint-lsp Node server and bundle it into the plugin distribution,
7473
// so the runtime finds it at <pluginPath>/xslint-lsp/node_modules/xslint-lsp.
7574
val xslintLspDir = layout.buildDirectory.dir("xslint-lsp")
75+
val npm = if (System.getProperty("os.name").startsWith("Windows", true)) "npm.cmd" else "npm"
7676

77-
val installXslintLsp by tasks.registering(Exec::class) {
77+
val installXslintLsp = tasks.register<Exec>("installXslintLsp") {
7878
val out = xslintLspDir.get().asFile
7979
val server = providers.gradleProperty("xslintLspVersion").get()
8080
outputs.dir(out)
8181
doFirst { out.mkdirs() }
8282
commandLine(
83-
"npm", "install", "--no-audit", "--no-fund",
83+
npm, "install", "--no-audit", "--no-fund",
8484
"--prefix", out.absolutePath, "xslint-lsp@$server",
8585
)
8686
}

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,4 @@ xslintLspVersion = 0.0.3
1515
kotlin.stdlib.default.dependency = false
1616

1717
org.gradle.caching = true
18-
org.gradle.jvmargs = -Xmx2g -XX:MaxMetaspaceSize=512m
18+
org.gradle.jvmargs = -Xmx4g -XX:MaxMetaspaceSize=768m

0 commit comments

Comments
 (0)