Skip to content

Commit be074d1

Browse files
committed
added width and height
1 parent 89ef285 commit be074d1

File tree

3 files changed

+11
-4
lines changed

3 files changed

+11
-4
lines changed

xcoll/beam_elements/fluka.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -226,6 +226,7 @@ def __init__(self, **kwargs):
226226
import xcoll as xc
227227
to_assign = {}
228228
generic = False
229+
import pdb; pdb.set_trace()
229230
if '_xobject' not in kwargs:
230231
kwargs.setdefault('_tracking', True)
231232
kwargs.setdefault('_acc_ionisation_loss', -1.)
@@ -252,6 +253,10 @@ def __init__(self, **kwargs):
252253
side = kwargs.pop('side', None)
253254
if side is None:
254255
raise ValueError('Need to provide side!')
256+
if 'width' in kwargs:
257+
width = kwargs.pop('width', None)
258+
if 'height' in kwargs:
259+
height = kwargs.pop('height', None)
255260
generic = True
256261
super().__init__(**kwargs)
257262
for key, val in to_assign.items():
@@ -262,7 +267,8 @@ def __init__(self, **kwargs):
262267
side = self._get_side_from_input(side)
263268
self.assembly = create_generic_assembly(is_crystal=True, material=material,
264269
side=side, length=self.length,
265-
bending_radius=bending_radius)
270+
bending_radius=bending_radius,
271+
width=width, height=height)
266272
if not hasattr(self, '_equivalent_drift'):
267273
self._equivalent_drift = xt.Drift(length=self.length)
268274

xcoll/scattering_routines/fluka/fluka_input.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -160,8 +160,8 @@ def _element_dict_to_fluka(element_dict, dump=False):
160160
offset = (ee._jaw_LU + ee._jaw_LD + ee._jaw_RU + ee._jaw_RD) / 4
161161
tilt_1 = round(ee.tilt_L, 9)
162162
tilt_2 = round(ee.tilt_R, 9)
163-
if abs(tilt_1) > 1.e-12 or abs(tilt_2) > 1.e-12:
164-
raise NotImplementedError(f"Collimator {name}: Tilts are not (yet) supported in FLUKA-Xcoll!")
163+
# if abs(tilt_1) > 1.e-12 or abs(tilt_2) > 1.e-12:
164+
# raise NotImplementedError(f"Collimator {name}: Tilts are not (yet) supported in FLUKA-Xcoll!")
165165

166166
if nsig is None:
167167
nsig = 1

xcoll/scattering_routines/fluka/generic_prototype.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,8 @@ def _validate_kwargs(kwargs):
115115
if field not in kwargs:
116116
raise ValueError(f"Need to provide {field}!")
117117
for field, opt_value in _generic_crystal_optional_fields.items():
118-
kwargs.setdefault(field, opt_value)
118+
if field not in kwargs:
119+
kwargs.setdefault(field, opt_value)
119120
else:
120121
for field in _generic_required_fields:
121122
if field not in kwargs:

0 commit comments

Comments
 (0)