Remove alt -> ctrl+arrow hack in favor of embedder-specific solutions

[Tyriar]

Context: #264 (comment)

Finding the commit they were added to confirm is also a good idea.

xterm.js/src/common/input/Keyboard.ts

Lines 114 to 189 in 8b42244

	case 37:
	// left-arrow
	if (ev.metaKey) {
	break;
	}
	if (modifiers) {
	result.key = C0.ESC + '[1;' + (modifiers + 1) + 'D';
	// HACK: Make Alt + left-arrow behave like Ctrl + left-arrow: move one word backwards
	// http://unix.stackexchange.com/a/108106
	// macOS uses different escape sequences than linux
	if (result.key === C0.ESC + '[1;3D') {
	result.key = C0.ESC + (isMac ? 'b' : '[1;5D');
	}
	} else if (applicationCursorMode) {
	result.key = C0.ESC + 'OD';
	} else {
	result.key = C0.ESC + '[D';
	}
	break;
	case 39:
	// right-arrow
	if (ev.metaKey) {
	break;
	}
	if (modifiers) {
	result.key = C0.ESC + '[1;' + (modifiers + 1) + 'C';
	// HACK: Make Alt + right-arrow behave like Ctrl + right-arrow: move one word forward
	// http://unix.stackexchange.com/a/108106
	// macOS uses different escape sequences than linux
	if (result.key === C0.ESC + '[1;3C') {
	result.key = C0.ESC + (isMac ? 'f' : '[1;5C');
	}
	} else if (applicationCursorMode) {
	result.key = C0.ESC + 'OC';
	} else {
	result.key = C0.ESC + '[C';
	}
	break;
	case 38:
	// up-arrow
	if (ev.metaKey) {
	break;
	}
	if (modifiers) {
	result.key = C0.ESC + '[1;' + (modifiers + 1) + 'A';
	// HACK: Make Alt + up-arrow behave like Ctrl + up-arrow
	// http://unix.stackexchange.com/a/108106
	// macOS uses different escape sequences than linux
	if (!isMac && result.key === C0.ESC + '[1;3A') {
	result.key = C0.ESC + '[1;5A';
	}
	} else if (applicationCursorMode) {
	result.key = C0.ESC + 'OA';
	} else {
	result.key = C0.ESC + '[A';
	}
	break;
	case 40:
	// down-arrow
	if (ev.metaKey) {
	break;
	}
	if (modifiers) {
	result.key = C0.ESC + '[1;' + (modifiers + 1) + 'B';
	// HACK: Make Alt + down-arrow behave like Ctrl + down-arrow
	// http://unix.stackexchange.com/a/108106
	// macOS uses different escape sequences than linux
	if (!isMac && result.key === C0.ESC + '[1;3B') {
	result.key = C0.ESC + '[1;5B';
	}
	} else if (applicationCursorMode) {
	result.key = C0.ESC + 'OB';
	} else {
	result.key = C0.ESC + '[B';
	}
	break;

[fifv]

Thank you Tyriar for saving my life. I have spent hours to figure out why my Alt key doesn't work...

For anyone who wants a workaround, here is my hack for Tabby (other terminals should be similar):

1. Open the file contains xterm.js's bundled codes (C:\Users\<USER>\AppData\Local\Programs\Tabby\resources\builtin-plugins\tabby-terminal\dist\index.js)

   • This is xterm.js ‘s problem, and Tabby use xterm.js as a plugin, note it belongs to builtin-plugins instead of main tabby app

2. Fix for Arrows:

   Find [1;5D (may ~27452 at Tabby 1.0.196)

   Remove these selected

   

3. Fix for PageUp/PageDown:

   Find [5~ (may ~27479 at Tabby 1.0.196, just near the above ones)

   Add these selected

   

[dmarcuse]

Is there any recent update on this? I've been frustrated by this behavior in VS code and finally figured out this was the cause (and found the linked workaround via VS code's shortcuts). I see the help wanted tag - if it's just a matter of getting someone to do it, I'm happy to make the changes.

[Tyriar]

@dmarcuse no updates, just needs someone to help out. We'll need this removed in xterm.js and then some default keybindings added to VS Code. So then disabling this in VS Code would be a matter or disabling keybindings (as opposed to creating new ones which is more difficult).

[dmarcuse]

Sounds good, I'll set aside some time to work on this over the weekend then.

[balthild]

You could just "fix" it by simply override the key binding if you're using vscode. Maybe the workbench.action.terminal.sendSequence action does not send sequences via xterm.js, but through conpty directly, so it would not be modified?

    {
        "key": "alt+left",
        "command": "workbench.action.terminal.sendSequence",
        "args": {
            "text": "\u001b[1;3D"
        },
        "when": "terminalFocus"
    },
    {
        "key": "alt+right",
        "command": "workbench.action.terminal.sendSequence",
        "args": {
            "text": "\u001b[1;3C"
        },
        "when": "terminalFocus"
    },

Result:

[Tyriar]

@balthild yep, we just need that keybinding built in to VS Code. So those keybindings added somewhere over here: https://github.com/microsoft/vscode/blob/3ae6c5ef651585b12870828230f214eed2e6ef07/src/vs/workbench/contrib/terminal/browser/terminal.contribution.ts#L245-L249

And then remove the overrides from xterm.js

[jpmorris]

You could just "fix" it by simply override the key binding if you're using vscode. Maybe the

Worked for me. Note: you cant have 'Send Keybindings To Shell' enabled:

microsoft/vscode#190629 (comment)