update symbol names: starts with '_' for internal symbols

Author: xueyulinn

codehawk/agents/code_review_planning_agent.py

@@ -28,14 +28,14 @@ class CodeReviewPlanning(BaseModel):
     questions: list[CodeReviewQuestion]
 
 
-agent = Agent(
+_agent = Agent(
     name="Code Review Planning Agent",
     instructions=PR_CODE_REVIEW_PLANNING_SYSTEM_PROMPT,
     output_type=CodeReviewPlanning,
 )
 
 
-def construct_user_prompt(
+def _construct_user_prompt(
     sat_summary: str,
     pr_files_context: PullRequestFilesContext,
     pr_info_context: PullRequestInfoContext,
@@ -119,12 +119,12 @@ async def generate_code_review_planning(
     pr_info_context: PullRequestInfoContext,
     pr_commits_context: PullRequestCommitsContext,
 ) -> CodeReviewPlanning:
-    prompt = construct_user_prompt(
+    prompt = _construct_user_prompt(
         sat_summary,
         pr_files_context,
         pr_info_context,
         pr_commits_context,
     )
     with trace("CODE_REVIEW_PLANNING"):
-        result = await Runner.run(agent, input=prompt)
+        result = await Runner.run(_agent, input=prompt)
         return result.final_output_as(CodeReviewPlanning)

codehawk/agents/code_review_writer_agent.py

@@ -23,14 +23,14 @@ class PRReviewOutput(BaseModel):
         description="The inline review comments to create on changed lines.")
 
 
-agent = Agent(
+_agent = Agent(
     name="Code Review Writer Agent",
     instructions=PR_CODE_REVIEW_WRITER_SYSTEM_PROMPT,
     output_type=PRReviewOutput
 )
 
 
-def construct_user_prompt(
+def _construct_user_prompt(
     sat_summary: str,
     pr_files_context: PullRequestFilesContext,
     structual_questions: Any,
@@ -64,12 +64,12 @@ def construct_user_prompt(
             ),
         },
         "planned_questions": {
-            "structural": to_jsonable(structual_questions),
-            "convention": to_jsonable(convention_questions),
+            "structural": _to_jsonable(structual_questions),
+            "convention": _to_jsonable(convention_questions),
         },
         "evidence": {
-            "structural": to_jsonable(structual_evidence),
-            "convention": to_jsonable(conventional_evidence),
+            "structural": _to_jsonable(structual_evidence),
+            "convention": _to_jsonable(conventional_evidence),
         },
     }
     context_json = json.dumps(prompt_context, ensure_ascii=False, indent=2)
@@ -90,7 +90,7 @@ async def generate_code_review_comments(
     conventional_evidence,
     pr_ctx: PRReviewContext,
 ) -> PRReviewOutput:
-    prompt = construct_user_prompt(
+    prompt = _construct_user_prompt(
         sat_summary,
         pr_files_context,
         structual_questions,
@@ -100,17 +100,17 @@ async def generate_code_review_comments(
         pr_ctx,
     )
     with trace("CODE_REVIEW_COMMENTS"):
-        result = await Runner.run(agent, input=prompt, context=pr_ctx)
+        result = await Runner.run(_agent, input=prompt, context=pr_ctx)
         return result.final_output_as(PRReviewOutput)
 
 
-def to_jsonable(value: Any) -> Any:
+def _to_jsonable(value: Any) -> Any:
     if hasattr(value, "model_dump"):
         return value.model_dump(mode="json")
     if isinstance(value, list):
-        return [to_jsonable(item) for item in value]
+        return [_to_jsonable(item) for item in value]
     if isinstance(value, tuple):
-        return [to_jsonable(item) for item in value]
+        return [_to_jsonable(item) for item in value]
     if isinstance(value, dict):
-        return {key: to_jsonable(item) for key, item in value.items()}
+        return {key: _to_jsonable(item) for key, item in value.items()}
     return value

codehawk/agents/convention_evidence_agent.py

@@ -58,15 +58,15 @@ async def find_similar_code_chunks(
     return json.dumps({"similar_code_chunks": results}, ensure_ascii=False)
 
 
-agent = Agent(
+_agent = Agent(
     name="Conventional Evidence Agent",
     instructions=PR_CONVENTION_EVIDENCE_SYSTEM_PROMPT,
     tools=[find_similar_code_chunks],
     output_type=CodeReviewEvidence,
 )
 
 
-def construct_user_prompt(
+def _construct_user_prompt(
     questions: list[CodeReviewQuestion],
     ctx: PRReviewContext,
 ) -> str:
@@ -109,7 +109,7 @@ async def generate_conventional_evidence(
     questions: list[CodeReviewQuestion],
     ctx: PRReviewContext,
 ) -> CodeReviewEvidence:
-    prompt = construct_user_prompt(questions, ctx)
+    prompt = _construct_user_prompt(questions, ctx)
     with trace("CONVENTIONAL_EVIDENCE"):
-        result = await Runner.run(agent, input=prompt, context=ctx)
+        result = await Runner.run(_agent, input=prompt, context=ctx)
         return result.final_output_as(CodeReviewEvidence)

codehawk/agents/pr_summary_agent.py

@@ -10,15 +10,15 @@
     PullRequestInfoContext,
 )
 
-pr_summary_agent = Agent(
+_pr_summary_agent = Agent(
     name="Github Pull Request Summary Agent",
     instructions=PR_SUMMARY_SYSTEM_PROMPT,
     model="gpt-5.5",
     model_settings=ModelSettings(verbosity="low")
 )
 
 
-def construct_pr_full_prompt(
+def _construct_pr_full_prompt(
     pr_info_context: PullRequestInfoContext,
     pr_commits_context: PullRequestCommitsContext,
     pr_files_context: PullRequestFilesContext,
@@ -120,7 +120,7 @@ def construct_pr_full_prompt(
     )
 
 
-def construct_pr_incremental_prompt(
+def _construct_pr_incremental_prompt(
     pr_incremental_context: PullRequestIncrementalCompareContext
 ) -> str:
     prompt_context = {
@@ -171,23 +171,23 @@ async def generate_pr_full_summary(
     pr_files_context: PullRequestFilesContext,
     reason: str | None = None,
 ) -> str:
-    pr_full_summary_prompt = construct_pr_full_prompt(
+    pr_full_summary_prompt = _construct_pr_full_prompt(
         pr_info_context,
         pr_commits_context,
         pr_files_context,
         reason
     )
     with trace("PR Full Summary Workflow"):
-        pr_summary = await Runner.run(pr_summary_agent, pr_full_summary_prompt)
+        pr_summary = await Runner.run(_pr_summary_agent, pr_full_summary_prompt)
         return pr_summary.final_output_as(str)
 
 
 async def generate_pr_incremental_summary(
     pr_incremental_context: PullRequestIncrementalCompareContext
 ) -> str:
-    pr_incremental_summary_prompt = construct_pr_incremental_prompt(
+    pr_incremental_summary_prompt = _construct_pr_incremental_prompt(
         pr_incremental_context,
     )
     with trace("PR Incremental Summary Workflow"):
-        pr_summary = await Runner.run(pr_summary_agent, pr_incremental_summary_prompt)
+        pr_summary = await Runner.run(_pr_summary_agent, pr_incremental_summary_prompt)
         return pr_summary.final_output_as(str)

codehawk/agents/sat_summary_agent.py

@@ -5,13 +5,13 @@
 from codehawk.agents.prompts import SAT_SUMMARY_SYSTEM_PROMPT
 from codehawk.models.sat import SATReportDTO, ToolResultDTO
 
-agent = Agent(
+_agent = Agent(
     name="Static Check Agent",
     instructions=SAT_SUMMARY_SYSTEM_PROMPT,
 )
 
 
-def construct_user_prompt(report: SATReportDTO | ToolResultDTO) -> str:
+def _construct_user_prompt(report: SATReportDTO | ToolResultDTO) -> str:
     if isinstance(report, SATReportDTO):
         prompt_context = {
             "report_type": "sat_report",
@@ -39,7 +39,7 @@ def construct_user_prompt(report: SATReportDTO | ToolResultDTO) -> str:
 async def run_sat_summary(report: SATReportDTO | ToolResultDTO) -> str:
     with trace("SAT Summary Workflow"):
         res = await Runner.run(
-            agent,
-            input=construct_user_prompt(report),
+            _agent,
+            input=_construct_user_prompt(report),
         )
         return res.final_output_as(str)

codehawk/agents/sat_summary_agent_json.py

@@ -28,14 +28,14 @@ class Report(BaseModel):
     items: list[Item]
 
 
-agent = Agent(
+_agent = Agent(
     name="Static Check JSON Agent",
     instructions=SAT_SUMMARY_JSON_SYSTEM_PROMPT,
     output_type=Report,
 )
 
 
-def construct_user_prompt(report: SATReportDTO | ToolResultDTO) -> str:
+def _construct_user_prompt(report: SATReportDTO | ToolResultDTO) -> str:
     if isinstance(report, SATReportDTO):
         prompt_context = {
             "report_type": "sat_report",
@@ -65,8 +65,8 @@ def construct_user_prompt(report: SATReportDTO | ToolResultDTO) -> str:
 
 async def run_sat_summary(report: SATReportDTO | ToolResultDTO) -> Report:
     with trace("SAT Summary Workflow"):
-        res = await Runner.run(
-            agent,
-            input=construct_user_prompt(report),
-        )
+        res = await Runner.run(
+            _agent,
+            input=_construct_user_prompt(report),
+        )
         return res.final_output_as(Report)

codehawk/agents/structural_evidence_agent.py

@@ -107,15 +107,15 @@ async def find_usage_patterns(
     return json.dumps({"usage_patterns": patterns}, ensure_ascii=False)
 
 
-agent = Agent(
+_agent = Agent(
     name="Structural Evidence Agent",
     instructions=PR_STRUCTURAL_EVIDENCE_SYSTEM_PROMPT,
     tools=[find_code_chunks, find_code_references, find_usage_patterns],
     output_type=CodeReviewEvidence,
 )
 
 
-def construct_user_prompt(
+def _construct_user_prompt(
     questions: list[CodeReviewQuestion],
     ctx: PRReviewContext,
 ) -> str:
@@ -158,7 +158,7 @@ async def generate_structural_evidence(
     questions: list[CodeReviewQuestion],
     ctx: PRReviewContext,
 ) -> CodeReviewEvidence:
-    prompt = construct_user_prompt(questions, ctx)
+    prompt = _construct_user_prompt(questions, ctx)
     with trace("STRUCTURAL_EVIDENCE"):
-        result = await Runner.run(agent, input=prompt, context=ctx)
+        result = await Runner.run(_agent, input=prompt, context=ctx)
         return result.final_output_as(CodeReviewEvidence)