@@ -62,6 +62,7 @@ public String index(HttpServletRequest request,
6262 @ RequestParam (value = "jobGroup" , required = false , defaultValue = "0" ) Integer jobGroup ,
6363 @ RequestParam (value = "jobId" , required = false , defaultValue = "0" ) Integer jobId ) {
6464
65+ // 1、init JobGroupList
6566 // find all jobGroup
6667 List <XxlJobGroup > jobGroupListTotal = xxlJobGroupMapper .findAll ();
6768
@@ -70,44 +71,31 @@ public String index(HttpServletRequest request,
7071 if (CollectionTool .isEmpty (jobGroupList )) {
7172 throw new XxlJobException (I18nUtil .getString ("jobgroup_empty" ));
7273 }
74+ List <Integer > jobGroupIds = jobGroupList .stream ().map (XxlJobGroup ::getId ).toList ();
7375
74- // parse jobGroup
76+ // 2、check jobId
7577 if (jobId > 0 ) {
76- // assign jobId (+ jobGroup)
78+ // valid jobId
7779 XxlJobInfo jobInfo = xxlJobInfoMapper .loadById (jobId );
7880 if (jobInfo == null ) {
79- // jobId not exist, inteceptor
8081 throw new RuntimeException (I18nUtil .getString ("jobinfo_field_id" ) + I18nUtil .getString ("system_unvalid" ));
8182 }
83+ // valid jobGroup
8284 jobGroup = jobInfo .getJobGroup ();
83- } else if (jobGroup > 0 ) {
84- // assign jobGroup
85- Integer finalJobGroup = jobGroup ;
86- if (CollectionTool .isEmpty (jobGroupListTotal .stream ().filter (item -> item .getId () == finalJobGroup ).toList ())) {
87- // jobGroup not exist, use first
88- jobGroup = jobGroupList .get (0 ).getId ();
89- }
90- jobId = 0 ;
91- } else {
92- // default first valid jobGroup
93- jobGroup = jobGroupList .get (0 ).getId ();
94- jobId = 0 ;
9585 }
9686
97- /*// valid permission
98- JobGroupPermissionUtil.validJobGroupPermission(request, jobGroup);*/
87+ // 3、init jobGroup, default first 1
88+ if (!jobGroupIds .contains (jobGroup )) {
89+ jobGroup = jobGroupList .get (0 ).getId ();
90+ }
9991
100- // find jobList
92+ // 4、init jobInfoList
10193 List <XxlJobInfo > jobInfoList = xxlJobInfoMapper .getJobsByGroup (jobGroup );
94+ List <Integer > jobIds = jobInfoList .stream ().map (XxlJobInfo ::getId ).toList ();
10295
103- // parse jobId
104- if (CollectionTool . isEmpty ( jobInfoList )) {
96+ // 5、init JobId, default 0
97+ if (! jobIds . contains ( jobId )) {
10598 jobId = 0 ;
106- } else {
107- if (!jobInfoList .stream ().map (XxlJobInfo ::getId ).toList ().contains (jobId )) {
108- // jobId not exist, use first
109- jobId = jobInfoList .get (0 ).getId ();
110- }
11199 }
112100
113101 // write
@@ -133,9 +121,9 @@ public Response<PageModel<XxlJobLog>> pageList(HttpServletRequest request,
133121 JobGroupPermissionUtil .validJobGroupPermission (request , jobGroup );
134122
135123 // valid jobId
136- if (jobId < 1 ) {
124+ /* if (jobId < 1) {
137125 return Response.ofFail(I18nUtil.getString("system_please_choose") + I18nUtil.getString("jobinfo_job"));
138- }
126+ }*/
139127
140128 // parse param
141129 Date triggerTimeStart = null ;
0 commit comments