Skip to content

Commit cc9695b

Browse files
committed
refactor(log): 移除冗余的日志读取方法
- 删除了 XxlJobFileAppender 中的 readLines 方法 -该方法功能已被其他实现替代,不再使用 - 简化了日志文件处理逻辑 - 减少了代码维护成本 - 避免潜在的资源泄漏问题- 提高了代码整洁度和可读性
1 parent 33662c0 commit cc9695b

1 file changed

Lines changed: 0 additions & 31 deletions

File tree

xxl-job-core/src/main/java/com/xxl/job/core/log/XxlJobFileAppender.java

Lines changed: 0 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -178,35 +178,4 @@ public static LogResult readLog(String logFileName, int fromLineNum){
178178
return new LogResult(fromLineNum, toLineNum, logContentBuilder.toString(), false);
179179
}
180180

181-
/**
182-
* read log data
183-
* @param logFile
184-
* @return log line content
185-
*/
186-
public static String readLines(File logFile){
187-
BufferedReader reader = null;
188-
try {
189-
reader = new BufferedReader(new InputStreamReader(new FileInputStream(logFile), "utf-8"));
190-
if (reader != null) {
191-
StringBuilder sb = new StringBuilder();
192-
String line = null;
193-
while ((line = reader.readLine()) != null) {
194-
sb.append(line).append("\n");
195-
}
196-
return sb.toString();
197-
}
198-
} catch (IOException e) {
199-
logger.error(e.getMessage(), e);
200-
} finally {
201-
if (reader != null) {
202-
try {
203-
reader.close();
204-
} catch (IOException e) {
205-
logger.error(e.getMessage(), e);
206-
}
207-
}
208-
}
209-
return null;
210-
}
211-
212181
}

0 commit comments

Comments
 (0)