Skip to content

Commit 0dd9888

Browse files
committed
Attempt of using java.nio.file for extension removal
* fix bad github merge
1 parent 5ba6179 commit 0dd9888

File tree

1 file changed

+2
-9
lines changed
  • xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-api/src/main/java/org/xwiki/extension/repository/internal/local

1 file changed

+2
-9
lines changed

xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-api/src/main/java/org/xwiki/extension/repository/internal/local/LocalExtensionStorage.java

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -339,7 +339,7 @@ public void removeExtension(DefaultLocalExtension extension) throws IOException
339339
deleteExtensionFolderIfEmpty(extensionVersionFolderPath.getParent());
340340
} catch (DirectoryNotEmptyException e) {
341341
LOGGER.warn("Extension version folder [{}] was not empty after removing the extension [{}]. Keeping it.",
342-
extensionDescriptorFilePath, extension.getId().getId());
342+
extensionDescriptorFilePath.toString(), extension.getId().getId());
343343
}
344344
}
345345

@@ -356,14 +356,7 @@ private static void deleteExtensionFolderIfEmpty(Path extensionFolderPath) throw
356356
} catch (DirectoryNotEmptyException e) {
357357
// Folder not being empty is a valid scenario if some version of the extension are still installed
358358
LOGGER.debug("Extension folder [{}] was not empty after removing the extension. Keeping it.",
359-
extensionFolderPath);
359+
extensionFolderPath.toString());
360360
}
361-
362-
// Delete extension version folder if empty
363-
File extensionVersionFolder = descriptorFile.getParentFile();
364-
extensionVersionFolder.delete();
365-
366-
// Delete extension folder if empty
367-
extensionVersionFolder.getParentFile().delete();
368361
}
369362
}

0 commit comments

Comments
 (0)