View-file macro ends up with an error in full mode

[lamblinc]

view-file macro seems broken on latest version.

Steps to reproduce

1. Install the Confluence Migration Toolkit
2. Add a view-file macro to a page
3. Include the example pptx file:
   Example file.pptx
4. Select full mode option and save the page

Expected behavior
The file is displayed in view mode

Actual behavior
Page displays an error:

org.xwiki.rendering.RenderingException: Failed to render asynchronously the work items displayer.
at wiki:xwiki//com.xwiki.macros.viewfile.internal.macro.async.ViewFileAsyncFullRenderer.execute(ViewFileAsyncFullRenderer.java:169)
at org.xwiki.rendering.async.internal.block.AbstractBlockAsyncRenderer.render(AbstractBlockAsyncRenderer.java:157)
at org.xwiki.rendering.async.internal.block.AbstractBlockAsyncRenderer.render(AbstractBlockAsyncRenderer.java:54)
at org.xwiki.rendering.async.internal.AsyncRendererJob.runInternal(AsyncRendererJob.java:101)
at org.xwiki.job.AbstractJob.runInContext(AbstractJob.java:246)
at org.xwiki.job.AbstractJob.run(AbstractJob.java:223)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:840)
Caused by: org.xwiki.rendering.macro.MacroExecutionException: Failed to view office attachment.
at org.xwiki.rendering.internal.macro.office.OfficeMacro.execute(OfficeMacro.java:115)
at org.xwiki.rendering.internal.macro.office.OfficeMacro.execute(OfficeMacro.java:56)
at wiki:xwiki//com.xwiki.macros.viewfile.internal.macro.async.ViewFileAsyncFullRenderer.prepareOfficeFile(ViewFileAsyncFullRenderer.java:200)
at wiki:xwiki//com.xwiki.macros.viewfile.internal.macro.async.ViewFileAsyncFullRenderer.prepareFullDisplay(ViewFileAsyncFullRenderer.java:176)
at wiki:xwiki//com.xwiki.macros.viewfile.internal.macro.async.ViewFileAsyncFullRenderer.execute(ViewFileAsyncFullRenderer.java:166)
... 8 more
Caused by: java.lang.IllegalStateException: The request object has been recycled and is no longer associated with this facade
at org.apache.catalina.connector.RequestFacade.checkFacade(RequestFacade.java:856)
at org.apache.catalina.connector.RequestFacade.getServletPath(RequestFacade.java:638)
at javax.servlet.http.HttpServletRequestWrapper.getServletPath(HttpServletRequestWrapper.java:213)
at javax.servlet.http.HttpServletRequestWrapper.getServletPath(HttpServletRequestWrapper.java:213)
at javax.servlet.http.HttpServletRequestWrapper.getServletPath(HttpServletRequestWrapper.java:213)
at com.xpn.xwiki.web.WrappingXWikiRequest.getServletPath(WrappingXWikiRequest.java:203)
at com.xpn.xwiki.XWiki.getServletPath(XWiki.java:5441)
at com.xpn.xwiki.web.XWikiServletURLFactory.addServletPath(XWikiServletURLFactory.java:350)
at com.xpn.xwiki.web.XWikiServletURLFactory.internalCreateAttachmentURL(XWikiServletURLFactory.java:748)
at com.xpn.xwiki.web.XWikiServletURLFactory.createAttachmentURL(XWikiServletURLFactory.java:725)
at com.xpn.xwiki.XWiki.getAttachmentURL(XWiki.java:5634)
at com.xpn.xwiki.XWiki.getAttachmentURL(XWiki.java:5645)
at com.xpn.xwiki.XWiki.getAttachmentURL(XWiki.java:5682)
at com.xpn.xwiki.doc.DefaultDocumentAccessBridge.getAttachmentURL(DefaultDocumentAccessBridge.java:841)
at com.xpn.xwiki.doc.DefaultDocumentAccessBridge.getAttachmentURL(DefaultDocumentAccessBridge.java:817)
at org.xwiki.officeimporter.internal.filter.ImageFilter.filterImageSource(ImageFilter.java:152)
at org.xwiki.officeimporter.internal.filter.ImageFilter.filter(ImageFilter.java:123)
at org.xwiki.xml.internal.html.DefaultHTMLCleaner.clean(DefaultHTMLCleaner.java:187)
at org.xwiki.officeimporter.internal.cleaner.OfficeHTMLCleaner.clean(OfficeHTMLCleaner.java:131)
at org.xwiki.officeimporter.internal.builder.DefaultPresentationBuilder.cleanPresentationHTML(DefaultPresentationBuilder.java:257)
at org.xwiki.officeimporter.internal.builder.DefaultPresentationBuilder.build(DefaultPresentationBuilder.java:144)
at org.xwiki.office.viewer.internal.DefaultOfficeResourceViewer.createXDOM(DefaultOfficeResourceViewer.java:347)
at org.xwiki.office.viewer.internal.DefaultOfficeResourceViewer.createXDOM(DefaultOfficeResourceViewer.java:311)
at org.xwiki.office.viewer.internal.DefaultOfficeResourceViewer.getView(DefaultOfficeResourceViewer.java:420)
at org.xwiki.office.viewer.internal.DefaultOfficeResourceViewer.createView(DefaultOfficeResourceViewer.java:477)
at org.xwiki.rendering.internal.macro.office.OfficeMacro.execute(OfficeMacro.java:113)
... 12 more

Environment (please complete the following information):

• OS: Manjaro Linux latest
• Browser Chromium 144.0.7559.59
• XWiki version 16.10.12, 17.10.2
• App version:
  Toolkit: 1.0.36 / 1.0.37
  Pro Macros / Pro Macros Confluence Bridges 1.29

[abrassat]

After more testing, it seems that any document which contains Shapes (rectangles, traingles, etc) are facing this issue.

I reproduced this issue using a docx with a rectangle in it, and removing the Shape makes it display properly.

There's also another issue with ppt files, as they aren't displayed at all by the view-file macro, but in that case no error is thrown. (opened #703 )

Note that I can only reproduce this exact issue on cloud, locally I get #703