Skip to content

Commit 51760d9

Browse files
committed
remove reduant code
1 parent 6598ddf commit 51760d9

File tree

3 files changed

+9
-30
lines changed

3 files changed

+9
-30
lines changed

fluss-common/src/main/java/org/apache/fluss/utils/PropertiesUtils.java

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,7 @@
1717

1818
package org.apache.fluss.utils;
1919

20-
import java.util.Arrays;
2120
import java.util.Map;
22-
import java.util.Set;
2321
import java.util.stream.Collectors;
2422

2523
/** Utility class for properties related helper functions. */
@@ -59,21 +57,6 @@ public static <V> Map<String, V> extractPrefix(Map<String, V> originalMap, Strin
5957
.collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue));
6058
}
6159

62-
public static <V> Map<String, V> extractPrefix(
63-
Map<String, V> originalMap, Class<? extends Enum<?>> enumClass) {
64-
Set<String> prefixes =
65-
Arrays.stream(enumClass.getEnumConstants())
66-
.map(Enum::toString)
67-
.collect(Collectors.toSet());
68-
69-
return originalMap.entrySet().stream()
70-
.filter(
71-
entry ->
72-
prefixes.stream()
73-
.anyMatch(prefix -> entry.getKey().startsWith(prefix)))
74-
.collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue));
75-
}
76-
7760
/** Filter out keys that start with the given prefix from the original map. */
7861
public static <T> Map<String, T> excludeByPrefix(Map<String, T> originalMap, String prefix) {
7962
return originalMap.entrySet().stream()

fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/catalog/FlinkCatalogFactory.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626

2727
import java.util.ArrayList;
2828
import java.util.Collections;
29+
import java.util.HashMap;
2930
import java.util.List;
3031
import java.util.Map;
3132
import java.util.Set;
@@ -69,7 +70,11 @@ public FlinkCatalog createCatalog(Context context) {
6970
helper.validateExcept(PREFIXES_TO_SKIP_VALIDATE.toArray(new String[0]));
7071
Map<String, String> options = context.getOptions();
7172
Map<String, String> securityConfigs = extractPrefix(options, CLIENT_SECURITY_PREFIX);
72-
Map<String, String> lakeCatalogProperties = extractPrefix(options, DataLakeFormat.class);
73+
74+
Map<String, String> lakeCatalogProperties = new HashMap<>();
75+
for (DataLakeFormat lakeFormat : DataLakeFormat.values()) {
76+
lakeCatalogProperties.putAll(extractPrefix(options, lakeFormat.toString()));
77+
}
7378

7479
return new FlinkCatalog(
7580
context.getName(),

fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/lake/LakeFlinkCatalog.java

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import org.apache.fluss.config.Configuration;
2222
import org.apache.fluss.flink.utils.DataLakeUtils;
2323
import org.apache.fluss.metadata.DataLakeFormat;
24+
import org.apache.fluss.utils.PropertiesUtils;
2425

2526
import org.apache.flink.table.catalog.Catalog;
2627
import org.apache.paimon.catalog.CatalogContext;
@@ -30,7 +31,6 @@
3031

3132
import java.lang.reflect.Method;
3233
import java.util.Map;
33-
import java.util.stream.Collectors;
3434

3535
import static org.apache.fluss.metadata.DataLakeFormat.ICEBERG;
3636
import static org.apache.fluss.metadata.DataLakeFormat.PAIMON;
@@ -71,18 +71,9 @@ public Catalog getLakeCatalog(
7171
+ ConfigOptions.TABLE_DATALAKE_FORMAT.key()
7272
+ "' is set.");
7373
}
74-
String dataLakePrefix = lakeFormat.toString() + ".";
7574
Map<String, String> catalogProperties =
76-
lakeCatalogProperties.entrySet().stream()
77-
.filter(entry -> entry.getKey().startsWith(dataLakePrefix))
78-
.collect(
79-
Collectors.toMap(
80-
entry ->
81-
entry.getKey()
82-
.substring(
83-
dataLakePrefix
84-
.length()),
85-
Map.Entry::getValue));
75+
PropertiesUtils.extractAndRemovePrefix(
76+
lakeCatalogProperties, lakeFormat + ".");
8677

8778
catalogProperties.putAll(
8879
DataLakeUtils.extractLakeCatalogProperties(tableOptions));

0 commit comments

Comments
 (0)