Skip to content

Commit a028630

Browse files
committed
Fix comment reflection
1 parent dd05f12 commit a028630

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

CHANGELOG.md

+6-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
# Changelog
22

33
## [Unreleased]
4+
## [0.2.9] - 2025-02-03
5+
### Fixed
6+
- Comment reflection uses ``engine_reflection`` option. Enabled by default reflection leads to speed penalty during `system.tables` lookup.
7+
48
## [0.2.8] - 2025-01-30
59
### Fixed
610
- Table primary key reflection uses ``engine_reflection`` option. Enabled by default reflection leads to speed penalty during `system.tables` lookup.
@@ -338,7 +342,8 @@ Log, TinyLog, Null.
338342
- Chunked `INSERT INTO` in one request.
339343
- Engines: MergeTree, CollapsingMergeTree, SummingMergeTree, Buffer, Memory.
340344

341-
[Unreleased]: https://github.com/xzkostyan/clickhouse-sqlalchemy/compare/0.2.8...HEAD
345+
[Unreleased]: https://github.com/xzkostyan/clickhouse-sqlalchemy/compare/0.2.9...HEAD
346+
[0.2.9]: https://github.com/xzkostyan/clickhouse-sqlalchemy/compare/0.2.8...0.2.9
342347
[0.2.8]: https://github.com/xzkostyan/clickhouse-sqlalchemy/compare/0.2.7...0.2.8
343348
[0.2.7]: https://github.com/xzkostyan/clickhouse-sqlalchemy/compare/0.2.6...0.2.7
344349
[0.2.6]: https://github.com/xzkostyan/clickhouse-sqlalchemy/compare/0.2.5...0.2.6

clickhouse_sqlalchemy/__init__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
from .sql import Table, MaterializedView, select
55

66

7-
VERSION = (0, 2, 8)
7+
VERSION = (0, 2, 9)
88
__version__ = '.'.join(str(x) for x in VERSION)
99

1010

clickhouse_sqlalchemy/drivers/base.py

+3
Original file line numberDiff line numberDiff line change
@@ -432,6 +432,9 @@ def get_table_comment(self, connection, table_name, schema=None, **kw):
432432
if not self.supports_table_comment_reflection:
433433
raise NotImplementedError()
434434

435+
if not self.engine_reflection:
436+
return {}
437+
435438
database = schema if schema else connection.engine.url.database
436439

437440
query = text(

0 commit comments

Comments
 (0)