Pop 'engine_reflection' from query string

xzkostyan · xzkostyan · commit e4b7af674b77 · 2025-02-03T16:58:04.000+03:00
diff --git a/clickhouse_sqlalchemy/drivers/http/base.py b/clickhouse_sqlalchemy/drivers/http/base.py
@@ -32,7 +32,7 @@ def create_connect_args(self, url):
         endpoint = url.query.get('endpoint', '')
 
         self.engine_reflection = asbool(
-            url.query.get('engine_reflection', 'true')
+            url.query.pop('engine_reflection', 'true')
         )
 
         kwargs.update(url.query)
diff --git a/clickhouse_sqlalchemy/drivers/native/base.py b/clickhouse_sqlalchemy/drivers/native/base.py
@@ -69,7 +69,7 @@ def create_connect_args(self, url):
             url = url.set(password=password)
 
         self.engine_reflection = asbool(
-            url.query.get('engine_reflection', 'true')
+            url.query.pop('engine_reflection', 'true')
         )
 
         return (url.render_as_string(hide_password=False), ), {}

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ def create_connect_args(self, url):`
`32`	`32`	`endpoint = url.query.get('endpoint', '')`
`33`	`33`
`34`	`34`	`self.engine_reflection = asbool(`
`35`		`- url.query.get('engine_reflection', 'true')`
	`35`	`+ url.query.pop('engine_reflection', 'true')`
`36`	`36`	`)`
`37`	`37`
`38`	`38`	`kwargs.update(url.query)`
Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ def create_connect_args(self, url):`
`69`	`69`	`url = url.set(password=password)`
`70`	`70`
`71`	`71`	`self.engine_reflection = asbool(`
`72`		`- url.query.get('engine_reflection', 'true')`
	`72`	`+ url.query.pop('engine_reflection', 'true')`
`73`	`73`	`)`
`74`	`74`
`75`	`75`	`return (url.render_as_string(hide_password=False), ), {}`